GNOME Bugzilla – Bug 142971
treeview doesn't allow to edit editable GtkCellRendererText by double-click
Last modified: 2018-04-15 00:16:06 UTC
Currently, the treeview doesn't allow users to edit an editable text cell renderer by double clicking it. This is fishy since you can start editing by first selecting it and then - after the double-click period - clicking it again. But if you press the button again before the period is over, it is only selected. This is really horrible usability-wise. regs, Chris
Created attachment 27937 [details] [review] Proposed patch against GTK+ 2.4. Applies cleanly against HEAD as well.
One thing to keep in mind is that double-clicking on a row fires the "row-activated" signal. So a behavior change to double-click-to-edit would probably have to check if the cell is editable or not first. The real question is one of expectations... Does the user expect double-clicking on a row to edit the cell under the pointer or does he/she expect it to perform the "activate" behavior (whatever that is). AFAIK, the current behavior is "always activate", so perhaps a CTRL+double-click could start the edit?
I think I like the idea of having a double click on an unselected row start editing. However I am seeing some problems too: * "row-activated" will not be emitted with the patch applied, because the button-press signal handler will return TRUE after it has start the editing operation. Row activation is handled later in the button-press handler and that code will not be reached. I guess some people might see this change as an API/ABI change, since it never returned TRUE and not activated the row in this case before ... * The expection problem is indeed another problem. I don't think a ctrl + double-click will help here, how many users are going to find out about that shortcut? Not sure what to do. I am afraid that we can't commit this patch at this stage.
Might be slightly related with #119906.
Comment on attachment 27937 [details] [review] Proposed patch against GTK+ 2.4. Applies cleanly against HEAD as well. Patch does not apply cleanly anymore ( https://git.gnome.org/browse/gtk+/tree/gtk/gtktreeview.c#n3209 ); setting needs-work status
We're moving to gitlab! As part of this move, we are moving bugs to NEEDINFO if they haven't seen activity in more than a year. If this issue is still important to you and still relevant with GTK+ 3.22 or master, please reopen it and we will migrate it to gitlab.
As announced a while ago, we are migrating to gitlab, and bugs that haven't seen activity in the last year or so will be not be migrated, but closed out in bugzilla. If this bug is still relevant to you, you can open a new issue describing the symptoms and how to reproduce it with gtk 3.22.x or master in gitlab: https://gitlab.gnome.org/GNOME/gtk/issues/new