After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 142351 - Build break in nautilus-extension-types.h
Build break in nautilus-extension-types.h
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: [obsolete] Builds
0.x.x [obsolete]
Other AIX
: High normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 142352 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-05-11 16:46 UTC by Michael.Wilson
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.7/2.8


Attachments
Proposed patch. (864 bytes, patch)
2004-07-24 12:15 UTC, Christian Neumair
none Details | Review

Description Michael.Wilson 2004-05-11 16:46:30 UTC
There is an extraneous "," at the end of the enum, on line 55 which causes a
build break on AIX using native compiler.
Comment 1 Michael.Wilson 2004-05-11 17:04:45 UTC
Could I add another extraneous "," error ?

It's in nautilus/src/nautilus-view-frame.c  at line 530.

Thanks.
Comment 2 Germán Poo-Caamaño 2004-05-11 23:53:42 UTC
*** Bug 142352 has been marked as a duplicate of this bug. ***
Comment 3 Matthew Gatto 2004-05-18 15:59:12 UTC
thanks for the report. so that this bug report doesn't get lost in the noise,
could you add a patch, mark the priority to High and possibly send the patch to
the nautilus mailing list with a pointer to the URL of this bug? thanks, and
sorry for the inconvenience.
Comment 4 Michael.Wilson 2004-05-18 16:40:14 UTC
Sorry for the missing references, here there are :

libnautilus-extension/nautilus-extension-types.h, line 55 :

In typedef enum NautilusOperationResult :

Change line
    NAUTILUS_OPERATION_IN_PROGRESS,
To
    NAUTILUS_OPERATION_IN_PROGRESS



src/nautilus-view-frame.c, line 530 :

In enum :
enum {
        BONOBO_PROPERTY_TITLE,
        BONOBO_PROPERTY_HISTORY,
        BONOBO_PROPERTY_SELECTION,
        BONOBO_PROPERTY_WINDOW_TYPE,
};


Change line
BONOBO_PROPERTY_WINDOW_TYPE,
To
BONOBO_PROPERTY_WINDOW_TYPE

Comment 5 Christian Neumair 2004-07-24 12:15:22 UTC
Created attachment 29847 [details] [review]
Proposed patch.

While one of the enums has been fixed already, the second is still bogus.
Comment 6 Alexander Larsson 2004-08-16 10:40:24 UTC
Patch commited to cvs. Thanks.