After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 141985 - vte does not respond to 'CSI 2 1 t' or 'CSI 2 0 t' with the correct window/icon title
vte does not respond to 'CSI 2 1 t' or 'CSI 2 0 t' with the correct window/ic...
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.11.x
Other Linux
: Normal normal
: ---
Assigned To: Behdad Esfahbod
Nalin Dahyabhai
Depends on:
Blocks: 137388
 
 
Reported: 2004-05-06 05:32 UTC by Mariano Suárez-Alvarez
Modified: 2006-08-17 21:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix the handling of 'CSI 2 1 t' and 'CSI 2 0 t' (919 bytes, patch)
2004-05-06 05:33 UTC, Mariano Suárez-Alvarez 		none Details | Review
Set WM_NAME/WM_ICON_NAME on the VteTerminal window (1.33 KB, patch)
2004-05-06 21:52 UTC, Mariano Suárez-Alvarez 		committed Details | Review

Description Mariano Suárez-Alvarez 2004-05-06 05:32:49 UTC 
Here comes a patch that fixes that.
Comment 1 Mariano Suárez-Alvarez 2004-05-06 05:33:38 UTC 
Created attachment 27414 [details] [review]
Fix the handling of 'CSI 2 1 t' and 'CSI 2 0 t'
Comment 2 Nalin Dahyabhai 2004-05-06 05:39:03 UTC 
This would reopen CAN-2003-0070, so I must decline.
Comment 3 Mariano Suárez-Alvarez 2004-05-06 06:25:16 UTC 
Hmm. Right.

Can you make vte set WM_NAME and WM_ICON_NAME on its window?
I'm trying to somehow solve bug 137388, and if CSI 2 1 t is a no-go, then that
seems to be enough to please vim...
Comment 4 Nalin Dahyabhai 2004-05-06 07:51:01 UTC 
That should be doable without too much ickiness.  GDK seems to provide an API
for setting properties on windows....
Comment 5 Mariano Suárez-Alvarez 2004-05-06 21:51:15 UTC 
Here comes a patch that does this. I don't think there are any other places
where the window/icon titles are set. Note this sets the properties on
realization, too.
Comment 6 Mariano Suárez-Alvarez 2004-05-06 21:52:00 UTC 
Created attachment 27441 [details] [review]
Set WM_NAME/WM_ICON_NAME on the VteTerminal window
Comment 7 Mariano Suárez-Alvarez 2004-06-05 09:08:37 UTC 
Reopening...
Comment 8 Olav Vitters 2004-07-08 23:07:41 UTC 
Patch ok to apply?

Marking NEW
Comment 9 Kjartan Maraas 2004-10-18 10:16:30 UTC 
Please review and commit if it's ok.
Comment 10 Behdad Esfahbod 2006-07-11 00:59:16 UTC 
2006-07-10  Behdad Esfahbod  <behdad@gnome.org>

        Bug 141985 – vte does not respond to 'CSI 2 1 t' or 'CSI 2 0 t' with
        the correct window/icon title
        Patch from Mariano Suárez-Alvarez

        * src/vte.c (vte_terminal_realize), src/vteseq.c
        * (vte_sequence_handler_set_title_internal): Set window/icon titles.
Comment 11 Behdad Esfahbod 2006-08-17 21:17:03 UTC 
The patch seems to cause crashes.  Bug 351696.  I'm sure I've seen a dupe too.