GNOME Bugzilla – Bug 139692
Some characters cannot be given as the theme name
Last modified: 2006-04-26 20:08:49 UTC
1. Open the themes control panel. 2. Choose 'Save Theme...'. 3. Type in some characters. Include ' " / ? * \ | in the characters you type. 4. Observe how the characters are not entered; absolutely no feedback is given and no explanation as to why is around. It looks like your keyboard's broken or badly configured. This makes it impossible to give a theme a name like 'Tristan's theme'. (Only confirmed in Gnome 2.6 on Linux.)
Confirming. It's ok to escape the unwanted chars I think, but just making it impossible to type them in without explanation is a bit weird.
Confirming.
Created attachment 38748 [details] [review] this is the patch to confirming the user,attaching a dialog box. hi, i have attached a dialogbox to confirm the user not to use those of invalid charecters. thanking , probir paul
I don't think showing an error dialog is a good solution rather it should allow to type those chars and should be able to save them. For example: we can create a file named "Tristan's theme" by "vi Tristan\'s\ theme". So, theme manager should be able to handle this.
Created attachment 39482 [details] [review] this patch accepts the charecters which include ' " / ? * \ | as the theme-name patch to accept the charecter like ' " / ? * \ | as the theme-name
The patch doesn't include any escaping mechanism for the backslash (/) character, which means if the user enters a theme name with a backslash, it doesn't get saved properly. I don't think there are any similar problems with the other characters when used as a part of the filename.
I am, of course, talking about forward slash (/), not backslash (\).
2006-04-26 Thomas Wood <thos@gnome.org> * gnome-theme-save.c: (str_remove_slash), (setup_directory_structure), (write_theme_to_disk), (gnome_theme_save_show_dialog): Fix bug 139692 - Some characters cannot be given as the theme name