After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 136738 - Yelp could use gtkmozembed for rendering
Yelp could use gtkmozembed for rendering
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Shaun McCance
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2004-03-10 11:10 UTC by Marco Pesenti Gritti
Modified: 2005-10-10 18:49 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
dirty hack (8.22 KB, patch)
2004-03-10 11:15 UTC, Marco Pesenti Gritti
needs-work Details | Review
update (15.88 KB, patch)
2004-03-11 14:43 UTC, Marco Pesenti Gritti
needs-work Details | Review

Description Marco Pesenti Gritti 2004-03-10 11:11:00 UTC
I'm going to attach an incomplete, dirty patch. It's not very useful but it
can give an idea of the performance on startup

The problems I found so far are:

1 yelp-window.c put the html widget in a scrolled window but gtkmozembed
has his own scrollbars (no way to change that)
2 I'm not sure what we would want to do at configure time. Support both
html rendererers, just one or what ...
Comment 1 Marco Pesenti Gritti 2004-03-10 11:15:56 UTC
Created attachment 25446 [details] [review]
dirty hack
Comment 2 Marco Pesenti Gritti 2004-03-10 11:18:58 UTC
Problem 3. Gtkmozembed requires LD_LIBRARY_PATH and MOZILLA_FIVE_HOME
to be set to $prefix/lib/mozilla-1.6. You will need to do it manually
if you want to try out the patch.
In epiphany we are forced to use a script. This is going to be fixed
with GRE, but blizzard work on GREifying gtkmozembed is stalled atm.
Comment 3 Marco Pesenti Gritti 2004-03-11 14:43:51 UTC
Created attachment 25522 [details] [review]
update
Comment 4 Marco Pesenti Gritti 2004-03-11 14:46:25 UTC
This one seem to work ... I'm sure there are bugs since I didnt test
it much.
I think we need to decide how to integrate it, then I can try to solve
the problems and cook a final patch.

Maybe it would make sense to make this a configure option so that we
can enable it later if it works well enough ?
Comment 5 Mikael Hallendal 2004-03-12 13:57:26 UTC
Marco: Any chance we could put something like this in it's own
library? I'd like to use it for Devhelp aswell, if nothing else
perhaps something like libegg? so that you can just copy it into your
source easily?
Comment 6 Marco Pesenti Gritti 2004-03-12 20:13:49 UTC
We decided to try to start something like gtkmozembed but based on GRE
and powerfull enough to be used in yelp/devhelp/epiphany without
having to extend it. I guess it could be a separate library either in
GNOME cvs or mozilla cvs. We could add it to the desktop in 2.8 and
port yelp/devhelp/epiphany to it. At some point we could stabilize the
API and add it to the platform ...
We are goint to talk to blizzard to see what he thinks. Btw
Micke/Shaun, do you think it would make sense ? Would you use it ?
Something to figure out is if we want an abstraction layer that can be
implemented also with other rendering engines or if we can do without.
Comment 7 Mikael Hallendal 2004-03-15 13:28:43 UTC
Marco, yeah, I'd definitely use it in Devhelp. I'm totally fed up with
Gtkhtml2 and I'm going to take a look at this patch and start using it
in Devhelp today. 

I don't see much point in having support for various rendering engines
in that library. To me the best would be if we could just go with
Gecko for GNOME and drop gtkhtml2 (and in the long run possibly gtkhtml3).
Comment 8 Don Scorgie 2004-10-12 16:25:09 UTC
Hi,

This is implemented in HEAD and should make it through to the next GNOME version
(2.10)
Comment 9 Marco Pesenti Gritti 2004-12-04 00:42:47 UTC
Should we close this one now?
Comment 10 Kjartan Maraas 2005-04-17 16:17:47 UTC
Not sure. Yelp never had a stable release it seems since it was punted for
2.10.0 because of a11y problems in gtkmozembed...
Comment 11 Shaun McCance 2005-10-10 18:49:51 UTC
Done, closing.