Bug 136430 – Crash when opening the trash folder

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 136430 - Crash when opening the trash folder


Summary:	Crash when opening the trash folder


Status:	RESOLVED FIXED

Product:	nautilus
Classification:	Core
Component:	Navigation
Version:	0.x.x [obsolete]
Hardware:	Other Linux

Importance:	High critical
Target Milestone:	---
Assigned To:	Nautilus Maintainers
QA Contact:	Nautilus Maintainers

URL:
Whiteboard:

Duplicates:	136601 (view as bug list)
Depends on:
Blocks:

Reported:	2004-03-07 09:12 UTC by Gustavo Giráldez
Modified:	2004-12-22 21:47 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
crash fix (1.47 KB, patch) 2004-03-07 09:17 UTC, Gustavo Giráldez	none	Details \| Review

Description Gustavo Giráldez 2004-03-07 09:12:52 UTC

I get a crash when clicking in the Trash icon from the desktop, or on
second try when opening the trash location from the Places menu in a
spatial window (browser window works fine).

(gdb) bt

+ Trace 44875

#0 _dl_sysinfo_int80
from /lib/ld-linux.so.2
#1 __waitpid_nocancel
from /lib/tls/libpthread.so.0
#2 libgnomeui_segv_handle
at gnome-ui-init.c line 741
#3 <signal handler called>
#4 g_logv
#5 g_log
#6 position_and_show_window_callback
at nautilus-window-manage-views.c line 1185
#7 trash_callback_check_done
at nautilus-trash-file.c line 195
#8 trash_file_call_when_ready
at nautilus-trash-file.c line 422
#9 nautilus_file_call_when_ready
at nautilus-file.c line 5459
#10 determined_initial_view_callback
at nautilus-window-manage-views.c line 1275
#11 got_file_info_callback
at nautilus-applicable-views.c line 135
#12 trash_callback_check_done
at nautilus-trash-file.c line 195
#13 trash_file_call_when_ready
at nautilus-trash-file.c line 422
#14 nautilus_file_call_when_ready
at nautilus-file.c line 5459
#15 nautilus_determine_initial_view
at nautilus-applicable-views.c line 168
#16 begin_location_change
at nautilus-window-manage-views.c line 1545
#17 nautilus_window_open_location
at nautilus-window-manage-views.c line 750
#18 nautilus_application_present_spatial_window
at nautilus-application.c line 1006
#19 open_location
at nautilus-window-manage-views.c line 686
#20 eel_marshal_VOID__STRING_LONG_LONG_POINTER
at eel-marshal.c line 1588
#21 g_closure_invoke
at gclosure.c line 437
#22 signal_emit_unlocked_R
at gsignal.c line 2436
#23 g_signal_emit_valist
at gsignal.c line 2195
#24 g_signal_emit
at gsignal.c line 2239
#25 nautilus_view_frame_open_location
at nautilus-view-frame.c line 1214
#26 open_location
at nautilus-view-frame-corba.c line 86
#27 execute_queued_functions
at nautilus-idle-queue.c line 66
#28 g_idle_dispatch
at gmain.c line 3742
#29 g_main_dispatch
at gmain.c line 1887
#30 g_main_context_dispatch
at gmain.c line 2433
#31 g_main_context_iterate
at gmain.c line 2514
#32 g_main_loop_run
at gmain.c line 2718
#33 gtk_main
at gtkmain.c line 1171
#34 main
at nautilus-main.c line 328
#6 position_and_show_window_callback
at nautilus-window-manage-views.c line 1185
#7 trash_callback_check_done
at nautilus-trash-file.c line 195

$6 = {trash = 0x957bce8,
  callback = 0x8087840 <position_and_show_window_callback>,
  callback_data = 0x9438d48, delegated_attributes = 0,
  non_delegated_attributes = NAUTILUS_FILE_ATTRIBUTE_METADATA,
  non_ready_files = 0x0, initializing = 0}

The attached patch fixes this issue by setting pending_file_for_position
before calling nautilus_file_call_when_ready, in
nautilus-window-manage-views.c.  I tested and it doesn't seem to have bad
effects, but I'm not sure this is the right fix.

Comment 1 Gustavo Giráldez 2004-03-07 09:17:13 UTC

Created attachment 25285 [details] [review]
crash fix

Comment 2 Paolo Borelli 2004-03-07 11:02:08 UTC

Bumping prio, because of the patch. Gustavo, can you also send to
nutilus-list? Nautilus maint like patches sent to the mailing list so
that they don't get lost in bugzilla spam.

Comment 3 Dave Camp 2004-03-07 21:40:29 UTC

looks good, please commit

Comment 4 Gustavo Giráldez 2004-03-07 21:50:06 UTC

Committed.

Comment 5 Matthew Gatto 2004-03-09 01:57:21 UTC

*** Bug 136601 has been marked as a duplicate of this bug. ***