After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 135644 - sys/oss/gstosssink.c does not build under NetBSD
sys/oss/gstosssink.c does not build under NetBSD
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other All
: Normal normal
: 0.7.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-02-27 23:01 UTC by Julio Merino
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Sample patch (1.06 KB, patch)
2004-02-27 23:02 UTC, Julio Merino
none Details | Review

Description Julio Merino 2004-02-27 23:01:52 UTC
The sys/oss/gstosssink.c file does not build under NetBSD, rendering 
gst-plugins unbuildable out of the box.  There are basically two problems 
in it: 
 
First, the SNDCTL_DSP_GETODELAY ioctl does not exist in NetBSD.  I'm not 
sure what it's supposed to do, and if it's really needed, but simply 
avoiding its use seem to work fine (it has been patched this way for a 
long time in pkgsrc, with no major problems, AFAICT).  I'm not aware of a 
better solution, though. 
 
Second, there is an ioctl(2) call that has only two arguments.  This is 
wrong, since NetBSD expects three.  All other calls in the file are 
correct, as they pass a null value as the third argument (they use a 
literal 0, though I think they should use NULL).  So the solution is to 
simply add a 0 as the third parameter to that call to make it work.
Comment 1 Julio Merino 2004-02-27 23:02:16 UTC
Created attachment 24878 [details] [review]
Sample patch
Comment 2 David Schleef 2004-02-27 23:38:20 UTC
Applied, thanks.