After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 135506 - pango_win32_face_list_sizes undeclared
pango_win32_face_list_sizes undeclared
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: win32
1.3.x
Other Linux
: Normal normal
: ---
Assigned To: Tor Lillqvist
pango-maint
Depends on:
Blocks:
 
 
Reported: 2004-02-26 15:39 UTC by J. Ali Harlow
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed fix (730 bytes, patch)
2004-02-26 15:39 UTC, J. Ali Harlow
none Details | Review

Description J. Ali Harlow 2004-02-26 15:39:09 UTC
pango_win32_face_list_sizes() is used (in pangowin32-fontmap.c) before it
is declared causing my linux-x-mingw32 build to fail (and presumably other
win32 targets also). Error as follows:

 mingw32-gcc -DHAVE_CONFIG_H -I. -I. -I.. -DPANGO_ENABLE_BACKEND
-DPANGO_ENABLE_ENGINE -DSYSCONFDIR=\"/home/support/vers/pango/mingw32/etc\"
-DLIBDIR=\"/home/support/vers/pango/mingw32/lib\"
-DMODULE_VERSION=\"1.4.0\" -DG_DISABLE_DEPRECATED -DPANGO_ENABLE_DEBUG
-I/home/support/vers/glib/mingw32/include/glib-2.0
-I/home/support/vers/glib/mingw32/lib/glib-2.0/include -I.. -Wall -MT
pangowin32-fontmap.lo -MD -MP -MF .deps/pangowin32-fontmap.Tpo -c
pangowin32-fontmap.c  -DDLL_EXPORT -DPIC -o .libs/pangowin32-fontmap.o
pangowin32-fontmap.c: In function `pango_win32_face_class_init':
pangowin32-fontmap.c:945: error: `pango_win32_face_list_sizes' undeclared
(first use in this function)
pangowin32-fontmap.c:945: error: (Each undeclared identifier is reported
only once
pangowin32-fontmap.c:945: error: for each function it appears in.)
pangowin32-fontmap.c: At top level:
pangowin32-fontmap.c:952: error: `pango_win32_face_list_sizes' used prior
to declaration
pangowin32-fontmap.c:952: warning: `pango_win32_face_list_sizes' defined
but not used
Comment 1 J. Ali Harlow 2004-02-26 15:39:30 UTC
Created attachment 24810 [details] [review]
Proposed fix
Comment 2 Hans Breuer 2004-02-28 23:39:53 UTC
also fixed by :

2004-02-28  Hans Breuer  <hans@breuer.org>

	* pango/pango.def : updated externals including
	patch from J. Ali Harlow <ali@juiblex.co.uk>, fixes bug #135518

	* pango/pangowin32-fontmap.c : implement list_sizes() and
	is_monospace() members