Bug 135089 – Wallpaper configuration crash on multiple file drop

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 135089 - Wallpaper configuration crash on multiple file drop


Summary:	Wallpaper configuration crash on multiple file drop


Status:	RESOLVED FIXED

Product:	gnome-control-center
Classification:	Core
Component:	Background
Version:	unspecified
Hardware:	Other other

Importance:	High major
Target Milestone:	---
Assigned To:	Rodney Dawes
QA Contact:	Control-Center Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2004-02-22 00:30 UTC by Francisco Camenforte Torres
Modified:	2004-12-22 21:47 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Patch to fix this (1.84 KB, patch) 2004-02-24 04:30 UTC, Kiran Kumar Immidi	none	Details \| Review

Description Francisco Camenforte Torres 2004-02-22 00:28:57 UTC

Distribution: Debian testing/unstable
Package: control-center
Severity: normal
Version: GNOME2.5.5 2.5.3
Gnome-Distributor: GARNOME
Synopsis: Wallpaper configuration crash on multiple file drop
Bugzilla-Product: control-center
Bugzilla-Component: background
Bugzilla-Version: 2.5.3
BugBuddy-GnomeVersion: 2.0 (2.5.4)
Description:
Description of the crash:
When I dropped several files (all of them .jpg images) into the
wallpaper selection dialog, it crashed.

Additional Information:

Gnome 2.5.5 from garnome 0.30.1, control center version 2.5.3.



Debugging Information:

Backtrace was generated from
'/home/gnomedev/garnome/bin/gnome-background-properties'

[New Thread 16384 (LWP 10067)]
0x409ddbd8 in waitpid () from /lib/libpthread.so.0

+ Trace 44451

Thread 1 (Thread 16384 (LWP 10067))

#0 waitpid
from /lib/libpthread.so.0
#1 __JCR_LIST__
from /home/gnomedev/garnome/lib/libgnomeui-2.so.0
#2 libgnomeui_segv_handle
at gnome-ui-init.c line 741
#3 __pthread_sighandler
from /lib/libpthread.so.0
#4 <signal handler called>
#5 bg_add_multiple_files
at gnome-wp-capplet.c line 198
#6 g_list_foreach
at glist.c line 669
#7 bg_properties_dragged_image
at gnome-wp-capplet.c line 293
#8 _gtk_marshal_VOID__OBJECT_INT_INT_BOXED_UINT_UINT
at gtkmarshalers.c line 1767
#9 g_closure_invoke
at gclosure.c line 437
#10 signal_emit_unlocked_R
at gsignal.c line 2436
#11 g_signal_emit_valist
at gsignal.c line 2195
#12 g_signal_emit_by_name
at gsignal.c line 2263
#13 gtk_drag_selection_received
at gtkdnd.c line 1247
#14 _gtk_marshal_VOID__BOXED_UINT
at gtkmarshalers.c line 1180
#15 g_closure_invoke
at gclosure.c line 437
#16 signal_emit_unlocked_R
at gsignal.c line 2436
#17 g_signal_emit_valist
at gsignal.c line 2195
#18 g_signal_emit_by_name
at gsignal.c line 2263
#19 gtk_selection_retrieval_report
at gtkselection.c line 1782
#20 _gtk_selection_notify
at gtkselection.c line 1584
#21 _gtk_marshal_BOOLEAN__BOXED
at gtkmarshalers.c line 82
#22 g_type_class_meta_marshal
at gclosure.c line 514
#23 g_closure_invoke
at gclosure.c line 437
#24 signal_emit_unlocked_R
at gsignal.c line 2474
#25 g_signal_emit_valist
at gsignal.c line 2205
#26 g_signal_emit
at gsignal.c line 2239
#27 gtk_widget_event_internal
at gtkwidget.c line 3554
#28 gtk_main_do_event
at gtkmain.c line 1601
#29 gdk_event_dispatch
at gdkevents-x11.c line 2111
#30 g_main_dispatch
at gmain.c line 1752
#31 g_main_context_dispatch
at gmain.c line 2300
#32 g_main_context_iterate
at gmain.c line 2381
#33 g_main_loop_run
at gmain.c line 2601
#34 gtk_main
at gtkmain.c line 1171
#35 main
at gnome-wp-capplet.c line 1441
#0 waitpid
from /lib/libpthread.so.0





------- Bug moved to this database by unknown@bugzilla.gnome.org 2004-02-21 19:28 -------

Unknown version 2.5.3 in product control-center. Setting version to the default, "unspecified".
Reassigning to the default owner of the component, control-center-maint@bugzilla.gnome.org.

Comment 1 Francisco Camenforte Torres 2004-02-22 00:31:21 UTC

Correction: there is one .png file in the selection. Crash also
happens when using the gtk file selector and using multiple selection.

Comment 2 Francisco Camenforte Torres 2004-02-22 00:36:11 UTC

Update: I think I isolated the crash. It happens with a file named
like this:

love%20hina%20-%2006.jpg

I even created an empty file with that name, and the crash still
happens, so seems like it is a problem with the filename.

Comment 3 Francisco Camenforte Torres 2004-02-22 11:36:02 UTC

Setting priority to high and severity to major since it's a crash.
Feel free to lart me if I'm making something stupid.

Comment 4 Kiran Kumar Immidi 2004-02-24 04:30:28 UTC

Created attachment 24710 [details] [review]
Patch to fix this

Comment 5 Kiran Kumar Immidi 2004-02-24 04:33:23 UTC

The '%' in the filename is the reason. %20 is translated to a space '
', and it looks for something like 'love hina - 06.jpg'. The attached
patch escapes the file name to handle the '%' properly.

Comment 6 Rodney Dawes 2004-02-24 20:56:51 UTC

Fixed in CVS now. The attached patch is insufficient to entirely fix
the issue. We need to escape the path string when discovering the
filename for the thumbnail to load, as well.