After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 131967 - [patch] Gnumeric 1.2.5: fix plugins/plot_xy/gog-xy.c compilation with gcc 2.95
[patch] Gnumeric 1.2.5: fix plugins/plot_xy/gog-xy.c compilation with gcc 2.95
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Compilation
1.2.x
Other All
: High major
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2004-01-20 00:00 UTC by Adrian Bunk
Modified: 2005-08-15 01:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to fix this issue (614 bytes, patch)
2004-01-20 00:01 UTC, Adrian Bunk
none Details | Review

Description Adrian Bunk 2004-01-20 00:00:32 UTC
I got the following compile error when trying to compile Gnumeric 1.2.5
using gcc 2.95:

<--  snip  -->

...
 gcc -DHAVE_CONFIG_H -I. -I. -I../../../../../..
-DGNOMELOCALEDIR=\"/usr/local/s
hare/locale\" -I../../../../../../src -I../../../../../../src
-I../../../../../.
. -I../../../../../.. -I../../../../../../src/cut-n-paste-code -DORBIT2=1
-D_REE
NTRANT -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include
-I/usr/lo
cal/include/libgsf-1 -I/usr/local/include/libxml2
-I/usr/local/include/gtk-2.0 -
I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0
-I/usr/local/includ
e/pango-1.0 -I/usr/local/include -I/usr/local/include/freetype2
-I/usr/X11R6/inc
lude -I/usr/local/include/libglade-2.0
-I/usr/local/include/libgnomecanvas-2.0 -
I/usr/local/include/libart-2.0 -I/usr/local/include/libgnome-2.0
-I/usr/local/in
clude/orbit-2.0 -I/usr/local/include/libbonobo-2.0
-I/usr/local/include/gconf/2 
-I/usr/local/include/gnome-vfs-2.0 -I/usr/local/lib/gnome-vfs-2.0/include
-I/usr
/local/include/bonobo-activation-2.0 -I/usr/local/include/libgnomeui-2.0
-I/usr/
local/include/libbonoboui-2.0 -I/usr/local/include/libgnomeprint-2.2
-I/usr/loca
l/include/libgnomeprintui-2.2 -O2 -mcpu=v8 -Wall -Wmissing-prototypes
-Wsign-com
pare -Wpointer-arith -Wnested-externs -Wchar-subscripts -Wwrite-strings -c
gog-x
y.c  -fPIC -DPIC -o .libs/gog-xy.o
...
gog-xy.c: In function `gog_bubble_plot_class_init':
gog-xy.c:364: parse error before `*'
gog-xy.c:366: `gog_2d_plot_klass' undeclared (first use in this function)
gog-xy.c:366: (Each undeclared identifier is reported only once
gog-xy.c:366: for each function it appears in.)
gog-xy.c: In function `gog_xy_view_render':
...
gog-xy.c: At top level:
gog-xy.c:52: warning: `gog_2d_view_get_type' declared `static' but never
defined
make[7]: *** [gog-xy.lo] Error 1
make[7]: Leaving directory
`/aux/adrian/build/gnumeric-1.2.5/src/cut-n-paste-cod
e/goffice/graph/plugins/plot_xy'

<--  snip  -->


gcc 2.95 doesn't allow variable declarations mixed with code.

I'll atach a patch in a minute.
Comment 1 Adrian Bunk 2004-01-20 00:01:38 UTC
Created attachment 23540 [details] [review]
patch to fix this issue
Comment 2 alexander.winston 2004-01-20 04:35:41 UTC
Upgrading the priority level to High and upgrading the severity level
to major.
Comment 3 Jody Goldberg 2004-01-20 16:51:41 UTC
Patch applied to both branches, but I will not be releasing 1.2.6 for
a while.  This problem seems relatively minor.  Apologies for letting
it slip through.