After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 131948 - xoverlay and gstplay sample fails to build - missing includes
xoverlay and gstplay sample fails to build - missing includes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Urgent blocker
: 0.7.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-01-19 18:08 UTC by Robert
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Robert 2004-01-19 18:08:24 UTC 
when doing a full build of the latest CVS, the gst-libs/gst/xoverlay libs,
and the examples/gstplay fail to build due to missing X11 includes in the
compile command. Adding /usr/X11R6/include fixes the problem - simple patch
for a developer to add in. (Same as the v4l compile bug fixd this morning)
Comment 1 Stephane Loeuillet 2004-01-24 03:09:07 UTC 
seems it was done for other modules but not for those you wrote here :
http://freedesktop.org/cgi-bin/viewcvs.cgi/*checkout*/gstreamer/gst-plugins/ChangeLog?rev=1.128

adding X_CFLAGS/X_LIBS should be enought
Comment 2 Robert 2004-02-05 21:50:14 UTC 
Actually, X_CFLAGS is already set and has the X11 include dir...
Problem is that X_CFLAGS is not called for those modules.

Again, is still an easy fix, but not being a coder, I can't seem to
track down where it is faulty.
I'll grab latest CVS and try it again and see if I can figure it out
and submit a patch if I do.
Comment 3 Benjamin Otte (Company) 2004-02-08 13:37:00 UTC 
2004-02-08  Benjamin Otte  <in7y118@public.uni-hamburg.de>
                                                                     
                                                                     
                              
        * gst-libs/gst/colorbalance/Makefile.am:
        * gst-libs/gst/navigation/Makefile.am:
        * gst-libs/gst/xoverlay/Makefile.am:
          remove unused GST_OPT_CFLAGS from Makefiles
          include X_CFLAGS and X_LIBS in xoverlay. (#131948)