After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 131416 - Switch to the next image on mouse wheel in fit mode
Switch to the next image on mouse wheel in fit mode
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
: 152942 164363 374689 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-01-14 08:35 UTC by Nickolay V. Shmyrev
Modified: 2015-05-06 18:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to CVS head (3.68 KB, patch)
2004-01-14 10:01 UTC, Nickolay V. Shmyrev
needs-work Details | Review
Mouse wheel preference patch (13.15 KB, patch)
2006-11-13 17:50 UTC, Michael Chudobiak
none Details | Review
Mouse wheel navigation-only patch (4.28 KB, patch)
2006-11-22 14:08 UTC, Michael Chudobiak
none Details | Review

Description Nickolay V. Shmyrev 2004-01-14 08:35:04 UTC
I so miss this feature!!
Comment 1 Nickolay V. Shmyrev 2004-01-14 10:01:20 UTC
Created attachment 23344 [details] [review]
Patch to CVS head
Comment 2 Paolo Bacchilega 2004-04-12 06:49:04 UTC
The patch is good, but the feature it adds is not.  The mouse wheel is used for
scrolling, and only for scrolling, adding other commands to the mouse wheel is a
hack, changing the mouse wheel behaviour on certain conditions (fit mode in this
case) is even a worst hack, so I'm sorry but I'll not apply your patch.
Comment 3 Nickolay V. Shmyrev 2004-04-12 07:38:42 UTC
I understand your reasons. 

Thanks.
Comment 4 Nickolay V. Shmyrev 2004-04-12 07:47:15 UTC
By the way, what about adding gconf key, disabled by default, which will enable
this feature?
Comment 5 Stefan Nicolin 2004-06-18 11:05:52 UTC
One more vote for the previous comment. Thanks
Comment 6 Jason Knight 2004-10-22 22:13:15 UTC
Yes, I would really enjoy a toggle in preferences to change this behavior (and
also page up/page down to switch images)
Comment 7 Esaltato 2004-11-22 14:04:31 UTC
>The mouse wheel is used for scrolling, and only for scrolling

Maybe in gthumb, surely not in most of this century's image browsers. 

>adding other commands to the mouse wheel is a hack

I'm not sure I get this one: is it a hack architecturally speaking, or is it a
hack usability speaking? Cause I might get the first (I'm not a programmer, and
 don't know how gnome handles certain mouse events) but not certainly the
second. The wheel is a tool, so it can be used in a lot of ways (and I do find
some different ways very useful, e.g. zooming or changing selections, if used
accordingly to good sense).

>changing the mouse wheel behaviour on certain conditions (fit mode in this
case) is even a worst hack

I hope you'll put the mouse wheel support in gthumb, since I found it is a big
lack in your otherwise very good program. A pref. check might be the key.
Comment 8 WareKala 2005-01-13 21:13:22 UTC
I would very much like this feature, it's just too stupid that gthumb is missing
something like this. Wheel on a mouse can be used for *so* many different things
than just scrolling up and down...
Comment 9 Sebastien Bacher 2005-01-15 23:24:40 UTC
*** Bug 152942 has been marked as a duplicate of this bug. ***
Comment 10 raimu 2005-05-25 10:48:33 UTC
The only thing I miss in gThumb: switching to prev/next image with mousewheel is
just so convenient.
A preferences option would be nice : it should work in all view modes (browsing
mode included, as long as the cursor is over the preview pane).
Comment 11 Tero Grundström 2005-06-14 16:51:31 UTC
My girlfriend is very non-technical i.e. an "average computer user" (in my
opinion anyway). She has a digital camera and a alot of photos and she uses
acdsee on win98 to manage her photos. When she browses her photos she uses this
scroll wheel feature extensively.

Because of the lack of this very convenient and common feature I really couldn't
recommend gthumb for her, if she ever becomes a Linux/Gnome user.
Comment 12 gareth 2006-02-12 02:35:32 UTC
Is there no intention of implementing this feature? 
I too think it is a very sensible way to use the mouse wheel and it is a behaviour that people expect in an image viewer these days (look at ACDSee and Picasa on Windows).
Comment 13 Michael Chudobiak 2006-09-22 19:06:42 UTC
*** Bug 164363 has been marked as a duplicate of this bug. ***
Comment 14 Michael Chudobiak 2006-11-05 17:28:51 UTC
I am willing to review/commit a patch that implements a GUI preference (with matching gconf pref of course) to control the function of the mouse wheel (scroll by default, forward/back by non-default).

The patch in comment 1 overloaded the mouse wheel with too many mode-dependent functions.

Nickolay - any interest in revising your patch to does this, for application against CVS HEAD? Or anyone else?

- Mike

Comment 15 Michael Chudobiak 2006-11-13 14:21:28 UTC
*** Bug 374689 has been marked as a duplicate of this bug. ***
Comment 16 Michael Chudobiak 2006-11-13 17:50:41 UTC
Created attachment 76500 [details] [review]
Mouse wheel preference patch

Here is a patch that adds a mouse wheel function preference. This only adds the preference setting - it doesn't use it yet.

Can I have a volunteer to build on this and make a patch to libgthumb/image-viewer.c to actually USE the preference?

You would do this by adding something like 

if (pref_get_mouse_wheel () == GTH_MOUSE_WHEEL_NAVIGATE)

or

if (pref_get_mouse_wheel () == GTH_MOUSE_WHEEL_SCROLL)

to the code. I don't quite understand the image-viewer.c scroll signal code, so I'd appreciate help.

- Mike
Comment 17 Paolo Bacchilega 2006-11-13 19:05:37 UTC
please do not add a preference for this feature, just implement the feature.
Comment 18 Michael Chudobiak 2006-11-22 14:08:58 UTC
Created attachment 77026 [details] [review]
Mouse wheel navigation-only patch

I have committed this attachment, adding mouse-wheel navigation. It is a simplified and updated version of Nickolay's patch.

This should appear in 2.9.0 shortly.

- Mike
Comment 19 Vitaly Bordug 2008-01-01 17:55:24 UTC
(In reply to comment #17)
> please do not add a preference for this feature, just implement the feature.
> 

seems way ago, but may I ask why there should be no pref about that?

I used gthumb since it was born and "great" behavior of ACDSee and others just makes me sick (and I am not sole in that , see  http://episteme.arstechnica.com/eve/forums/a/tpc/f/96509133/m/300006015831/inc/1 for instance). I don't think one-way changes are a great way to move forward, sorry.

Comment 20 Jeremy Nickurak 2010-10-03 04:05:36 UTC
I've just filed https://bugzilla.gnome.org/show_bug.cgi?id=631205 , which documents another major pitfall with this feature.
Comment 21 Leho Kraav (@lkraav :macmaN) 2015-05-06 18:42:02 UTC
Googling "gthumb mousewheel". A whole bunch of discussion trying to find a way to have mousewheel scroll instead of navigate. This should be a preference.