GNOME Bugzilla – Bug 129205
GNOME Speech API shouldn't be implementation dependent.
Last modified: 2004-12-22 21:47:04 UTC
The existing GNOME Speech API should not expose the underlying implementation. That should be hidden so that if there is a need to change it at a later date, then this can be made completely transparent to the consumers of that API.
Created attachment 22380 [details] Changes need to existing GNOME Speech files.
Created attachment 22381 [details] New Speech source files (implementation agnostic API with a hidden Bonobo/ORBit2 implementation).
There were two existing files I needed to change in the gnome-speech module: .../gnome-speech/Makefile.am .../gnome-speech/configure.in The diffs for these are in the attachment "gnome-speech.diffs". There were two new directories created called: .../gnome-speech/speech .../gnome-speech/test-capi These directories have the following new files: .../gnome-speech/speech/Makefile.am .../gnome-speech/speech/speech.h .../gnome-speech/speech/speech_callback.c .../gnome-speech/speech/speech_callback.h .../gnome-speech/speech/speech_impl.c .../gnome-speech/speech/speech_impl.h .../gnome-speech/speech/speech_main.c .../gnome-speech/speech/speech_main.h .../gnome-speech/speech/speech_parameter.c .../gnome-speech/speech/speech_parameter.h .../gnome-speech/speech/speech_servers.c .../gnome-speech/speech/speech_servers.h .../gnome-speech/speech/speech_speaker.c .../gnome-speech/speech/speech_speaker.h .../gnome-speech/speech/speech_synthesis_driver.c .../gnome-speech/speech/speech_synthesis_driver.h .../gnome-speech/speech/speech_types.h .../gnome-speech/speech/speech_voice_info.c .../gnome-speech/speech/speech_voice_info.h .../gnome-speech/test-capi/Makefile.in .../gnome-speech/test-capi/test-speech-capi.c I've attached a "cfiles.tgz" compressed tarball with all these new files in them. They (and the two new parent directories) will need to be "cvs add"'ed before you do a gnome-speech commit.
Note these changes are to GNOME Speech v0.2.X and don't include the slight adjustments to the API for GNOME Speech v0.3.
Rich: your attachment is unreadable, so I cannot eval. can you send it as a patch (-uN) instead of application/bin? thanks
gnome-speech IS implementation independant; that's why it's IDL! I do not believe that this is a bug. The only implementation dependence is the use of CORBA_Environment as the exception/return mechanism; probably a necessary evil with dealing with CORBA backends at this time. It's more important to keep gnome-speech language-independent, which is the other reason for retaining the IDL as the normative interface.
Bill, the attachment is fine. I've just read it successfully and so did Michael Meeks. Save it with your browser and call it something like cfiles.tar.gz. Then unpack with gunzip and tar.
the proposal would make gnome-speech language dependant, which is bad. the implementation details are not directly exposed via most bindings, it's only that CORBA C bindings expose more ugliness than other CORBA bindings (via the corba environment variable).
After discussion we've decided not to provide non-normative C bindings to gnome-speech.