After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 129176 - [PATCH] Fix some FreeBSD issues in gnome-system-monitor
[PATCH] Fix some FreeBSD issues in gnome-system-monitor
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
unspecified
Other FreeBSD
: High normal
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2003-12-12 08:15 UTC by Joe Marcus Clarke
Modified: 2011-11-11 10:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix FreeBSD issues in gnome-system-monitor (839 bytes, patch)
2003-12-12 08:15 UTC, Joe Marcus Clarke 		none Details | Review
Patch to fix FreeBSD and support NetBSD (2.54 KB, patch)
2004-02-19 12:18 UTC, Julio Merino 		none Details | Review

Description Joe Marcus Clarke 2003-12-12 08:15:13 UTC 
The attached patch fixes some compilation issues and unresolved symbol
issues in gnome-system-monitor-2.5.2.  There may be some functionality lost
due to the lack of grantpt and unlockpt.
Comment 1 Joe Marcus Clarke 2003-12-12 08:15:55 UTC 
Created attachment 22363 [details] [review]
Fix FreeBSD issues in gnome-system-monitor
Comment 2 Kevin Vandersloot 2003-12-12 14:05:01 UTC 
Looks good to me. Can you commit it yourself? Thanks a lot :)
Comment 3 Joe Marcus Clarke 2003-12-12 17:04:55 UTC 
Nope, sorry.  I'm just a lowly porter :-).
Comment 4 alexander.winston 2004-01-27 18:52:34 UTC 
Adding the portability keyword.
Comment 5 Julio Merino 2004-02-19 12:18:00 UTC 
The original patch in this report is quite limited, because it only 
recognizes FreeBSD and assumes that functions are not there based on 
the fact it's FreeBSD (this is right, but what will happen if, some 
day, these functions become part of it?). 
 
gnome-system-monitor also has build problems in NetBSD, because all 
these functions are missing, too.  Furthermore, the program needs to 
be linked against -lutil, which provides ttyname(3). 
 
I've attached a new patch that aims to be more flexible.  It checks 
for these functions from configure and also adds -lutil to LIBS in 
case we are running NetBSD. 
 
It could be very good if this was applied before GNOME 2.6 ;-)
Comment 6 Julio Merino 2004-02-19 12:18:35 UTC 
Created attachment 24549 [details] [review]
Patch to fix FreeBSD and support NetBSD
Comment 7 Joe Marcus Clarke 2004-02-19 18:23:27 UTC 
Yes, this is much better.
Comment 8 Paolo Borelli 2004-04-29 16:42:21 UTC 
Looks like Kevin accepted the first patch... since people seems to agree that
the second one is better, can this go in now that we are post freeze?
Comment 9 Benoît Dejean 2005-01-16 12:15:33 UTC 
there's nothing left to fix as procman now uses libgnomesu