After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 128959 - Use of SPI_KEYMASK_MOD2 instead of SPI_KEYMASK_NUMLOCK
Use of SPI_KEYMASK_MOD2 instead of SPI_KEYMASK_NUMLOCK
Status: RESOLVED FIXED
Product: gnopernicus
Classification: Deprecated
Component: keyboard&mouse
unspecified
Other Solaris
: Normal major
: ---
Assigned To: ps
ps
AP2
Depends on: 129103
Blocks:
 
 
Reported: 2003-12-10 09:41 UTC by padraig.obriain
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (11.16 KB, patch)
2003-12-10 09:43 UTC, padraig.obriain 		none Details | Review
Updated patch (15.72 KB, patch)
2003-12-12 08:32 UTC, padraig.obriain 		none Details | Review

Description padraig.obriain 2003-12-10 09:41:59 UTC 
The code in gnopernicus/kbd_mouse/libke/libke.c uses SPI_KEYMASK_MOD2. This
will work on linux but not on SOlaris.
Comment 1 padraig.obriain 2003-12-10 09:43:29 UTC 
Created attachment 22286 [details] [review]
Proposed patch
Comment 2 padraig.obriain 2003-12-11 16:51:03 UTC 
This patch is not correct.
Comment 3 padraig.obriain 2003-12-12 08:32:58 UTC 
Created attachment 22364 [details] [review]
Updated patch
Comment 4 padraig.obriain 2003-12-12 08:35:24 UTC 
The upadted patch replaces calls to
SPI_registerAccessibleKeyStrokeListener with SPI_KEYMASK_MOD2 and
SPI_KEYMASK_MOD3 with a call using SPI_KEYMASK_NUMLOCK.
Comment 5 ps 2003-12-12 10:20:03 UTC 
I tested it on my linux RH8.0 system, and I get the following warning
messages. As result the layers are not working using
SPI_KEYMASK_NUMLOCK. I use last at-spi version from 11.12.2003 .
"Warning: AT-SPI error: registering keystroke listener: Unknown CORBA
exception id: 'IDL:omg.org/CORBA/COMM_FAILURE:1.0'
Warning: AT-SPI error: registering keystroke listener: Unknown CORBA
exception id: 'IDL:omg.org/CORBA/COMM_FAILURE:1.0'
Warning: AT-SPI error: registering keystroke listener: Unknown CORBA
exception id: 'IDL:omg.org/CORBA/COMM_FAILURE:1.0'
Warning: AT-SPI error: registering keystroke listener: Unknown CORBA
exception id: 'IDL:omg.org/CORBA/COMM_FAILURE:1.0'
Warning: AT-SPI error: registering keystroke listener: Unknown CORBA
exception id: 'IDL:omg.org/CORBA/COMM_FAILURE:1.0'
Warning: AT-SPI error: registering keystroke listener: Unknown CORBA
exception id: 'IDL:omg.org/CORBA/COMM_FAILURE:1.0'
Warning: AT-SPI error: registering keystroke listener: Unknown CORBA
exception id: 'IDL:omg.org/CORBA/COMM_FAILURE:1.0'
"
Comment 6 padraig.obriain 2003-12-12 10:28:25 UTC 
Yes. This is a consequence of bug #129103. Try using at-spi from CVS
HEAD.
Comment 7 bill.haneman 2003-12-12 11:28:56 UTC 
bumping up severity since it breaks gnopernicus controls on Solaris.
Comment 8 padraig.obriain 2003-12-12 11:34:29 UTC 
It does not actually break Solaris as gnopernicus registers for MOD2
and MOD3 instead of NUMLOCK.
Comment 9 bill.haneman 2003-12-12 11:42:55 UTC 
agreed, this isn't a hard stopper then.  But the patch should go in
now that the at-spi bug has been identified and fixed.
Comment 10 remus draica 2003-12-17 14:55:22 UTC 
Padraig, can you apply the patch?
Comment 11 padraig.obriain 2004-01-02 11:01:45 UTC 
Patch committed to CVS HEAD.