GNOME Bugzilla – Bug 128893
configure doesn't fail when the user is using a version of libfaad which is too old
Last modified: 2004-12-22 21:47:04 UTC
Debian sarge has libfaad 1.1.0 (which is old) with which the faad decoder compilation fails, even if configure passed successfully. I'll attach the error log when I get a chance to retry to compile it.
aad.c -fPIC -DPIC -o .libs/libgstfaad_la-gstfaad.o gstfaad.c: In function `gst_faad_srcgetcaps': gstfaad.c:232: error: `FAAD_FMT_DOUBLE' undeclared (first use in this function) gstfaad.c:232: error: (Each undeclared identifier is reported only once gstfaad.c:232: error: for each function it appears in.) gstfaad.c: In function `gst_faad_srcconnect': gstfaad.c:329: error: `FAAD_FMT_DOUBLE' undeclared (first use in this function) gstfaad.c: In function `gst_faad_chain': gstfaad.c:386: warning: passing arg 3 of `faacDecInit' makes pointer from integer without a cast gstfaad.c:386: warning: passing arg 4 of `faacDecInit' from incompatible pointer type gstfaad.c:386: error: too many arguments to function `faacDecInit' gstfaad.c:399: error: too many arguments to function `faacDecDecode' gstfaad.c:407: error: structure has no member named `samplerate' gstfaad.c:409: error: structure has no member named `samplerate'
Configure has code to check for this: dnl **** Free AAC Decoder (FAAD) **** translit(dnm, m, l) AM_CONDITIONAL(USE_FAAD, true) GST_CHECK_FEATURE(FAAD, [AAC decoder plug-in], faad, [ GST_CHECK_LIBHEADER(FAAD, faad, faacDecOpen, -lm, faad.h, FAAD_LIBS="-lfaad -lm") AC_MSG_CHECKING([Checking for FAAD >= 2]) AC_TRY_COMPILE([ #include <faad.h> #if !defined(FAAD2_VERSION) #error Not faad2 #endif ], [ return 0; ], [ HAVE_FAAD="yes" && AC_MSG_RESULT(yes)], [ HAVE_FAAD="no" && AC_MSG_RESULT(no)]) AS_SCRUB_INCLUDE(FAAD_CFLAGS) AC_SUBST(FAAD_LIBS) ]) Can you try to finetune this so it works? I only have faad2 so I'm not exactly sure how to catch this. It'd help if you could attach config.log, too...
I'm attaching my faad.h header, it has #define FAAD2_VERSION "1.1" in it.
Created attachment 22256 [details] faad.h
Created attachment 22257 [details] config.log
<rant> Why do these people do that? </rant> Would it help if I check for FAAD_FMT_DOUBLE to assure we've got faad >= 2 (see attached patch)?
Created attachment 22260 [details] [review] patch for configure.ac
Ok, this patch works for me checking faad.h usability... yes checking faad.h presence... yes checking for faad.h... yes checking Checking for FAAD >= 2... no configure: *** These plugins will not be built: faad
Good. Can you commit it please? My configure.ac has more mess in it which shouldn't be committed yet...
Done