After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 128636 - gnome-panel should use the new gtk+ 2.3 file chooser
gnome-panel should use the new gtk+ 2.3 file chooser
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-12-06 00:38 UTC by Jan Arne Petersen
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
This patch replaces GtkFileSelection with GtkFileChooser. (3.91 KB, patch)
2003-12-06 00:39 UTC, Jan Arne Petersen 		none Details | Review

Description Jan Arne Petersen 2003-12-06 00:38:27 UTC 
gnome-panel should use the new gtk+ 2.3 file chooser in the run dialog.
Comment 1 Jan Arne Petersen 2003-12-06 00:39:48 UTC 
Created attachment 22142 [details] [review]
This patch replaces GtkFileSelection with GtkFileChooser.
Comment 2 Luis Villa 2003-12-09 04:37:01 UTC 
Adding the PATCH keyword so that these show up. Thanks a lot, jpetersen.
Comment 3 Vincent Untz 2003-12-10 09:54:50 UTC 
Looks ok, except for that:

gtk_window_set_default_size (GTK_WINDOW (chooser), 600, 400);

I don't think this should be hard-coded. You should use
gdk_screen_get_width/height and do some maths with it. Maybe something
like:

#define FILE_CHOOSER_MAX_WIDTH 600
screen_width = gdk_screen_get_width (gtk_widget_get_screen (widget));
width = MIN (FILE_CHOOSER_MAX_WIDTH, 3 * (screen_width / 4))
Comment 4 Mark McLoughlin 2003-12-10 12:13:02 UTC 
Actually, I'd just remove the set_default_size() thing. If it looks
broken, then that's a gtk+ bug.
Comment 5 Federico Mena Quintero 2003-12-10 20:07:00 UTC 
The patch in http://bugzilla.gnome.org/show_bug.cgi?id=129020 should
fix part of this.  Jan-Arne is also going to look into fixing vertical
sizing.  So, yes, the patch for gnome-panel should not have any
set_default_size() calls.
Comment 6 Vincent Untz 2003-12-11 20:20:16 UTC 
Ok, I committed a slightly modified version of this patch.
Thanks