After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 127004 - [PATCH] Keyboard Shortcuts dialog too wide
[PATCH] Keyboard Shortcuts dialog too wide
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] Keybinding
2.4.x
Other Linux
: High normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 130575 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-11-14 19:57 UTC by Pierre Sarrazin
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (837 bytes, patch)
2003-12-30 20:37 UTC, Emmanuel Pacaud
none Details | Review
A real patch, forget the former :) (5.45 KB, patch)
2003-12-30 20:42 UTC, Emmanuel Pacaud
none Details | Review
Message can be extracted from xgettext now (5.16 KB, patch)
2004-02-19 06:31 UTC, Sven Herzberg
none Details | Review

Description Pierre Sarrazin 2003-11-14 19:57:16 UTC
The dialog displayed by gnome-keybinding-properties 2.4.0 is too wide
when using the French locale (e.g., fr_CA).  This seems to be due to
the length of some translations.

To reproduce:
LC_ALL=fr_CA gnome-keybinding-properties

The dialog's width is about a thousand pixels.  The first shortcut
displayed under the Desktop (Bureau) category is "Show the panel
run dialog", which in French is "Affiche la boîte de dialogue de
lancement d'applications du tableau de bord."  One other string
is even longer than this one.  Since both columns of the table
take the width of the widest string, the dialog becomes very wide.

Perhaps there could be a policy for the translation teams to
use abbreviations where possible to keep the translations at
about the same length as the English original.  This problem
happens in several GNOME/GTK+ applications.

Another idea would be to avoid having *both* columns of the
table be the same width.  The 2nd column in this case does not
need to be wide.
Comment 1 Andrew Sobala 2003-11-20 13:49:16 UTC
Not setting the columns to be the same width should fix it.
Comment 2 Emmanuel Pacaud 2003-12-30 20:36:37 UTC
Columns area not set to the same width. The problem is the second
column has it size fixed by the string "Type a new accelerator, or
backspace to clear" (and a longer sentence in french), which is
visible when you select a row.

Please find a patch that set the sentence to only "<New
accelerator...>" and displays an information below tree. (tree row
seems a strange place to display information to user).
Comment 3 Emmanuel Pacaud 2003-12-30 20:37:51 UTC
Created attachment 22782 [details] [review]
Patch
Comment 4 Emmanuel Pacaud 2003-12-30 20:42:55 UTC
Created attachment 22783 [details] [review]
A real patch, forget the former :)
Comment 5 Matthew Gatto 2004-01-06 00:30:27 UTC
*** Bug 130575 has been marked as a duplicate of this bug. ***
Comment 6 Matthew Gatto 2004-01-06 00:32:55 UTC
Changing Priority -> High (patch) and changing Summary to better
reflect issue.
Comment 7 Jody Goldberg 2004-02-17 23:35:08 UTC
I usually test this sort of thing in German but it looks like French
wins the run-on-translated-sentence this time around.  Lets see if the
translation team will ok it.
Comment 8 Christian Rose 2004-02-18 20:56:39 UTC
From a quick glance at the patch, I'm not sure how the defined
TOOLTIP_TEXT is supposed to get translated?
Comment 9 Emmanuel Pacaud 2004-02-18 21:25:11 UTC
I guess this line:

#define TOOLTIP_TEXT "<New accelerator...>"

should be changed to:

static char TOOLTIP_TEXT=N_("<New accelerator...>");
Comment 10 Sven Herzberg 2004-02-19 06:31:40 UTC
Created attachment 24539 [details] [review]
Message can be extracted from xgettext now
Comment 11 Jody Goldberg 2004-03-11 19:30:20 UTC
damn this slipped through the cracks
It should go into 2.6.1
Comment 12 Jody Goldberg 2004-03-31 22:30:15 UTC
Applied