GNOME Bugzilla – Bug 125819
Unable to format from the desktop w/o mounting the disk
Last modified: 2009-11-09 12:03:05 UTC
Steps to reproduce: 1)Mount a floppy disk 2)Right click on the floppy icon that appears on desktop 3)Click on Format option, This does not function because the floppy is mounted. This is the only way the format option can be accessed on floppy icon. Should we provide any other option to do so?.
Right click on floppy icon on desktop, choose Format option, nautilus invokes gfloppy to format it. Since floppy is already mounted, gfloppy throws an error and terminates. But when the user Unmounts, the floppy icon on desktop disappears. Since Formating by making right click on desktop icon can not be done, providing an Format option for desktop icon by nautilus appears to be of no use. Either nautilus should not provide this option or gfloppy should do one of the following when right click->format option is chosen for an desktop icon, Case 1) gfloppy should unmount floppy and then format. Case 2) A check box be provided in gfloppy UI having an option to re-mount after formatting? Choosing re-mount option, it has to Unmount->format->re-mount the floppy. Case 3) A dialog should popup indicating "Device already mounted, Do you want to unmount?" with "Ok" or "Cancel" buttons?. If Ok button is clicked then it should unmount and format it. One more question arises here, Should it re-mount it? Other than using desktop icon of floppy to format is user has to unmount manually (if already mounted), then invoke Floppy Formatter (Applicatins->System tools->Floppy Formatter) and start format.
Created attachment 21268 [details] [review] The patch fixes the bug.
Stef, can you have a look at this please?
My apologies, I didn't see this one in my mail. I am currently checking the patch.
I've sent a mail to Alex Larsson about the new gnome-vfs-volume handling, because this bug may not be relevant for Gnome 2.5 (because volume-management is now centralized in the "My Computer" method). I asked him if he could provide a "Format" menu item when the device isn't mounted or the way he thinkgs we should implement this.
Comment on attachment 21268 [details] [review] The patch fixes the bug. I don't want to put in this patch based on the comments from Stef. We need to rethink this patch and see how it aligns with the new computer location/volume management proposal.
There is no format option when i right click on the floppy icon present on desktop after mounting. The version of GNOME i am using is 2.9(cvs head) and the operating system is Novell Linux Desktop. The only way i can format a floppy is using gfloppy.
Created attachment 64354 [details] [review] nautilus patch to remove the format option in mounted floppy I confirme that there is no "Format" option anymore in when I right click on the floppy icon on the desktop, using GNOME 2.14.1. But it is still present on the floppy icon in computer:/// This patch remove the format option if the drive is mounted.
Xavier: I'm marking attachment 64354 [details] [review] as needs-work, because you'll also have to patch FMDirectoryView. Note that due to recent changes the patch for HEAD will be different from the patch for the gnome-2-14 branch. For HEAD, you'll also have to add similar code to file_should_show_self.
Created attachment 64462 [details] [review] patch against HEAD Here is the patch for nautilus HEAD. Christian: Don't understand what you mean, my patch is for FMDirectoryView...
I think christian meant nautilus-places-sidebar.c too. I commited the HEAD patch with that added. However, it seems better to me if gfloppy could unmount the floppy before formating. When that is added we should revert the nautilus patch.
This bug was reported at https://launchpad.net/distros/ubuntu/+source/gnome-utils/+bug/47934 as well.
And I also reported it for Mandriva : http://qa.mandriva.com/show_bug.cgi?id=24590
thanks for your bug report. GFloppy has been removed from the GNOME Utilities since the 2.28.0 release, and replaced by the GNOME Disk Utility.