After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 124690 - gnome-mag magnifier should use WM_STRUTs
gnome-mag magnifier should use WM_STRUTs
Status: RESOLVED FIXED
Product: gnome-mag
Classification: Deprecated
Component: magnifier-utility
unspecified
Other All
: Normal major
: ---
Assigned To: bill.haneman
bill.haneman
AP2
: 124533 (view as bug list)
Depends on: 144126
Blocks:
 
 
Reported: 2003-10-15 17:40 UTC by bill.haneman
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.7/2.8

Attachments
patch to provide STRUTS if not override-redirect (8.92 KB, patch)
2004-06-10 22:46 UTC, bill.haneman 		none Details | Review
corrected screenshot (155.17 KB, image/png)
2004-06-11 11:28 UTC, bill.haneman 		  Details
improved and corrected struts patch (14.79 KB, patch)
2004-06-11 13:03 UTC, bill.haneman 		committed Details | Review

Description bill.haneman 2003-10-15 17:40:59 UTC 
gnome-mag should probably use 'struts' to hint to the WM that windows
should not be placed in its reserved region.  This would be useful for
non-fullscreen magnification applications.
Comment 1 bill.haneman 2003-10-20 13:30:02 UTC 
*** Bug 124533 has been marked as a duplicate of this bug. ***
Comment 2 bill.haneman 2004-04-08 21:13:16 UTC 
This should only happen (i.e. mag uses STRUTS) when
* Xcomposite is not available;
* source == target;
Comment 3 bill.haneman 2004-06-03 09:42:56 UTC 
escalating to AP2 since gdm will need this (see gdm bug 143634).
Comment 4 bill.haneman 2004-06-03 09:44:31 UTC 
setting gnome version to 2.7/2.8 because accessible login will need this.
Comment 5 bill.haneman 2004-06-10 22:46:12 UTC 
Created attachment 28573 [details] [review]
patch to provide STRUTS if not override-redirect

problem with this patch is that it requires that mag window not be
override-redirect; this is because of the way window managers and STRUTS work. 
You can't have both (without weird hacks like invisible windows that set STRUTS
while the 'real' window is override-redirect, etc.).
It also adds a command-line arg, --override-redirect, which allows
override-redirect behavior to be maintained when desired.  Perhaps it would be
better to use --struts instead, so that the default was
override-redirect/no-struts, since the latter is possibly better for fullscreen
magnification.	Hard to know without testing.
Comment 6 bill.haneman 2004-06-11 11:28:34 UTC 
Created attachment 28590 [details]
corrected screenshot

it helps to apply the STRUT patch first (sorry).  Second screenshot shows
Mozilla "mostly" confined to the LHS of the screen, but clearly too wide.  I
can attach one more screenshot showing that the 'struts' seem to be observed
properly with respect to draggin window borders...
Comment 7 bill.haneman 2004-06-11 13:03:31 UTC 
Created attachment 28596 [details] [review]
improved and corrected struts patch
Comment 8 bill.haneman 2004-06-11 13:04:11 UTC 
Note that even with the above corrections, bug 144126 still is present.