After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 124253 - Use the notification area icon in the about window
Use the notification area icon in the about window
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: notification area
unspecified
Other Linux
: Normal minor
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-10-09 22:53 UTC by Vincent Untz
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (2.65 KB, patch)
2003-10-09 22:54 UTC, Vincent Untz 		none Details | Review
Better patch. (2.62 KB, patch)
2003-10-14 12:16 UTC, Vincent Untz 		none Details | Review
Patch using GtkIconTheme. (1.79 KB, patch)
2003-10-22 10:29 UTC, Vincent Untz 		none Details | Review

Description Vincent Untz 2003-10-09 22:53:01 UTC 
It'd be nice to have the icon of the notification area in the about window
instead of the default GNOME logo.
I will attach a patch.
Comment 1 Vincent Untz 2003-10-09 22:54:13 UTC 
Created attachment 20615 [details] [review]
Proposed patch.
Comment 2 Vincent Untz 2003-10-14 12:16:18 UTC 
Created attachment 20691 [details] [review]
Better patch.
Comment 3 Havoc Pennington 2003-10-21 15:47:16 UTC 
Can't we use the new icon theme API in GTK or isn't there an icon
theme object already created in libgnome? I ask because creating icon
themes is apparently a bit expensive.

The notification area icon isn't a battery still is it?
Comment 4 Vincent Untz 2003-10-22 00:23:49 UTC 
This is just for the about window. The icon is no more the battery one
in the panel's context menu.
As for your question about the theme stuff, I don't know, so I'll wait
for an answer from Alex :-)
Comment 5 Alexander Larsson 2003-10-22 09:20:03 UTC 
Creating an icon theme object is indeed quite expensive. However,
there currently is no such object in GnomeProgram or anything. I think
moving to the new Gtk+ icon theme code would be bettter, because then
the icon theme object can be shared with the one used for normal gtk+
icon theming.
Comment 6 Vincent Untz 2003-10-22 10:29:07 UTC 
Created attachment 20859 [details] [review]
Patch using GtkIconTheme.
Comment 7 Vincent Untz 2003-10-22 10:32:00 UTC 
I don't have GTK+ CVS installed, so I can't test the patch. But does
it look ok? If yes, I'll try to remove all the GnomeIconTheme stuff in
gnome-panel as soon as I'll get GTK+ 2.3.x.
Comment 8 Mark McLoughlin 2004-02-04 10:03:48 UTC 
Re-assigning to gnome-panel-maint. Apologies for the spam.
Comment 9 Mark McLoughlin 2004-02-04 10:28:20 UTC 
Vincent: patch looks fine apart from the fact that you don't
check/free the GError
Comment 10 Vincent Untz 2004-02-05 19:26:30 UTC 
Committed (I removed the GError stuff since the gnome_about_new falls
back on the foot icon if there is no icon provided).