GNOME Bugzilla – Bug 124157
gfig - Lock Grid needs a tooltip
Last modified: 2003-10-17 19:09:46 UTC
The following items in Gfig dont have tooltips: Snap to Grid, Display Grid and Lock Grid The first two are pretty much self explanatory but I'm not entirely sure what Lock Grid actually does. I'll look at the code of course but if it is not obvious from just the label then a Tooltip would definately be a good idea. I should note that Gfig is full of really useful tooltips which have made it much easier to write the documetation I am currently working on (but cant quite seem to finish).
Looking at the sourcecode reveals that Lock Grid actually does... uhhh.. nothing ;) I don't have a clue what it is supposed to do, but it is unimplemented yet. I propose to just remove this feature. Alan, do you think we should still have tooltips for Snap to Grid and Display Grid? If yes, please make a proposal, and I will add them to gfig.
Trivial to fix, therefor setting milestone to 2.0
I mailed Andy Tai (original author of Gfig) about this and hopefully I'll get a reply soon. If you do remove this from the user interface it might be best to just comment it out and leave it in the code. As for Snap to Grid, Display Grid and Lock Grid I think they should have tooltips but I'm not too sure what would be appropriate Tooltips would be as they are pretty straight forward (although I am tempted to change Display Grid to "Show Grid" and to put it before Snap to Grid because I think it is logical towant to show the Grid before you start snapping to it).
2003-10-17 Maurits Rijk <lpeek.mrijk@consunet.nl> * plug-ins/gfig/gfig.c: commented out code for Lock Grid (which wasn't implemented). Fixes #124157. I also added tooltips, but they don't contain any useful information yet. Alan, do you have a suggestion for the tips? Please e-mail directly to me. I'm closing this bug.
Maurits, I saw you also changed capitalization in the GFig plug-in. Although the HIG suggests this style, I don't think it's a good idea to start changing this now. It seems that consistency is more important than HIG conformance and it is IMO too late to do this change all over the place. After all you want to give the translators a chance to finish there translations. Since we are close to a release, string changes should be done with care. The capitalization changes should be done after 2.0 is out.
2003-10-17 Sven Neumann <sven@gimp.org> * plug-ins/gfig/gfig.c: reverted most of Maurits changes (not the bug-fix though). The tentative feature freeze we are in also implies a string freeze. It's too late for such massive string changes.
I thought that the strings would only be frozen after the release of 2.0-rc1. But maybe it makes sense to freeze them now. Anyway, to be sure that we do not forget to re-apply Maurits' patch, I have now opened a separate bug report: see bug #124834.
I closed that report as a duplicate of bug #123699. There is no strict string freeze in effect yet but it's definitely too late to change the capitalization since that would affect several hundreds if not thousands of strings. This is not an option since we target a prerelease in a few weeks and we want to ship 2.0 with complete translations.
Andy said he just never quite got around to implementing lock Grid. I'm satisfied with Maurits patch, thanks.