After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 123946 - [PATCH] mpeg2dec-0.3.2-cvs run failure
[PATCH] mpeg2dec-0.3.2-cvs run failure
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.6.x
Other All
: Normal major
: 0.6.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-10-06 12:03 UTC by Ronald Bultje
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
give it a go (982 bytes, patch)
2003-10-06 12:04 UTC, Ronald Bultje
none Details | Review
This one works with 0.3.1, too (1.14 KB, patch)
2003-10-06 12:11 UTC, Ronald Bultje
none Details | Review
binary compatible with both libmpeg2 0.3.1 and 0.3.2 (1.16 KB, patch)
2003-10-07 10:11 UTC, Ronald Bultje
none Details | Review

Description Ronald Bultje 2003-10-06 12:03:35 UTC
Fix attached. Works for me. Please test.
Comment 1 Ronald Bultje 2003-10-06 12:04:21 UTC
Created attachment 20496 [details] [review]
give it a go
Comment 2 Ronald Bultje 2003-10-06 12:11:40 UTC
Created attachment 20497 [details] [review]
This one works with 0.3.1, too
Comment 3 Ronald Bultje 2003-10-06 12:14:55 UTC
One comment: 0.3.2/0.3.1 are binary *incompatible*. This is caused by
the state being -1 in 0.3.1 at the end of a buffer. In 0.3.2, this is
STATE_BUFFER, which is 0.

This can be fixed by  changing the two parts that refer to
STATE_BUFFER (which is 0 in 0.3.2 and -1 in 0.3.1...) and make them
check for both STATE_BUFFER and -1 and then define STATE_BUFFER as 0,
as it is in 0.3.2. I personally consider this pretty ugly, but it's a
way of fixing it...

Opinions?
Comment 4 Ronald Bultje 2003-10-07 10:10:44 UTC
I've implemented checking for both STATE_BUFFER (0) and -1 in CVS, so
that binaries of this plugin will work with both libmpeg2-0.3.1 and
-0.3.2. Patch is same as above, but with STATE_BUFFER defined as 0
instead of -1, and the two checks in the code where it checks for
state being STATE_BUFFER need an additional check for state == -1.
Comment 5 Ronald Bultje 2003-10-07 10:11:58 UTC
Created attachment 20525 [details] [review]
binary compatible with both libmpeg2 0.3.1 and 0.3.2
Comment 6 David I. Lehn 2003-10-07 21:06:28 UTC
To avoid confusion please refer to the CVS version of mpeg2dec as
"0.3.2-cvs" rather than "0.3.2".  The interface may change before
0.3.2 is released.  Thanks.
Comment 7 Thomas Vander Stichele 2003-10-08 09:08:52 UTC
commited to 0.6.3.1 and HEAD, closing