After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 123933 - the button has no accessible name
the button has no accessible name
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: show-desktop-button
1.5.x
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-10-06 08:25 UTC by remus draica
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (947 bytes, patch)
2003-10-06 14:05 UTC, padraig.obriain 		none Details | Review

Description remus draica 2003-10-06 08:25:17 UTC 
The "Show Desktop Button" has no accessible name.
Comment 1 Mark McLoughlin 2003-10-06 11:04:42 UTC 
What is an accessible name ?
Comment 2 padraig.obriain 2003-10-06 11:13:52 UTC 
I will propose a patch.
Comment 3 bill.haneman 2003-10-06 12:24:32 UTC 
Mark:

Please see 'GNOME Accessibility for Developers'

http://developer.gnome.org/projects/gap/guide/gad/

specifically, the section "Coding Guidelines for Supporting
Accessibility":

http://developer.gnome.org/projects/gap/guide/gad/gad-coding-guidelines.html
Comment 4 padraig.obriain 2003-10-06 14:05:02 UTC 
Created attachment 20507 [details] [review]
Proposed patch
Comment 5 remus draica 2003-10-07 10:09:14 UTC 
Patch is OK.
Comment 6 padraig.obriain 2003-10-07 10:30:24 UTC 
Mark,

May I commit this fix to HEAD and gnome-2-4 branch?
Comment 7 Mark McLoughlin 2003-10-07 11:13:17 UTC 
Why set it on the toggle button in this case and on the applet in the
other patch ?
Comment 8 padraig.obriain 2003-10-07 12:17:14 UTC 
The toggle button can focus but in the other bug the GtkImage can not
focus so the focusable widget is the appplet. We put the name on the
object can can focus.
Comment 9 Mark McLoughlin 2003-10-07 12:20:33 UTC 
ah, that makes some sense. Looks good to commit to HEAD only ...
Comment 10 padraig.obriain 2003-10-07 12:40:41 UTC 
In this case the string is not a new string but reusing the string in
the gnome-about box. Is this enough to allow it into the gnome-2-4
branch?
Comment 11 Mark McLoughlin 2003-10-07 12:44:03 UTC 
Good point - it should be fine for 2.4 in that case. But why is there
no accessible description ?
Comment 12 padraig.obriain 2003-10-07 12:51:18 UTC 
The widget has a tooltip and this is used as accessible description if
an accessible description is not explicitly specified.
Comment 13 Mark McLoughlin 2003-10-07 13:05:46 UTC 
Fair enough ... yet more voodoo though :-)
Comment 14 padraig.obriain 2003-10-07 13:12:35 UTC 
Patch committed to HEAD and gnome-2-4 branch.
Comment 15 bill.haneman 2003-10-07 13:50:16 UTC 
Mark:  the coding guidelines document makes reference to this fact
(about tooltips) also.