After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 123390 - cddb-slave2-properties crashes on startup
cddb-slave2-properties crashes on startup
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: CDDBSlave2
2.4.x
Other FreeBSD
: High blocker
: ---
Assigned To: gnome media maintainers
gnome media maintainers
Depends on:
Blocks:
 
 
Reported: 2003-09-27 21:26 UTC by Pav Lucistnik
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
crashfix (408 bytes, patch)
2003-09-27 21:27 UTC, Pav Lucistnik
none Details | Review

Description Pav Lucistnik 2003-09-27 21:26:30 UTC
cddb-slave2-properties crashes on startup with this output:

info: 0
Program received signal SIGBUS, Bus error.

The problem is that a Gtk Widget is being referenced before it's created.
Here is a backtrace:

(gdb) bt
  • #0 g_type_check_instance_cast
    at gtype.c line 2767
  • #1 create_dialog
    at cddb-slave-capplet.c line 842
  • #2 main
    at cddb-slave-capplet.c line 984
  • #3 _start
    at /usr/src/lib/csu/i386-elf/crt1.c line 104

(gdb) list
837             gtk_tree_view_append_column (GTK_TREE_VIEW
(pd->freedb_server), col);
838
839             gtk_container_add (GTK_CONTAINER (sw), pd->freedb_server);
840
841             g_signal_connect (G_OBJECT (pd->update), "clicked",
842                               G_CALLBACK (update_clicked), pd);
843
844             /* create the update server list button */
845             align = gtk_alignment_new (1.0, 0.5, 0.0, 0.0);
846

and here is the patch (see attachment). The fix is obvious, the same code
(lines 841-842) is repeated at lines 848-849. I assume that 841-842 is
forgotten code that should gone away in revision 1.18
Comment 1 Pav Lucistnik 2003-09-27 21:27:11 UTC
Created attachment 20328 [details] [review]
crashfix
Comment 2 Kjartan Maraas 2003-09-30 20:14:26 UTC
Adding keywords.
Comment 3 Ted Gould 2003-10-05 09:53:34 UTC
Committed to HEAD and gnome-2-4.  Thanks for the patch.