GNOME Bugzilla – Bug 123383
Add "Rate song" menu item/keybinding
Last modified: 2018-05-24 10:23:51 UTC
Package: rhythmbox Severity: enhancement Version: 0.5.3 Synopsis: Request for improved keybinding support Bugzilla-Product: rhythmbox Bugzilla-Component: Interface Description: Description of Problem: Better support for keys-only control of RhythmBox would be nice. In particular, key-based control of volume and ratings would be useful. As far as I can tell, this requires a mouse at the moment. Suggested actions: Volume control: e.g. Ctrl-<Up/Down Cursor> Ratings control: e.g. pressing 1-5 when the Rating area is focused ------- Bug moved to this database by unknown@bugzilla.gnome.org 2003-09-27 14:59 ------- The original reporter (buckley@hep.phy.cam.ac.uk) of this bug does not have an account here. Reassigning to the exporter, unknown@bugzilla.gnome.org. Reassigning to the default owner of the component, rhythmbox-maint@bugzilla.gnome.org.
I shall look into this issue with the usability guys to find the proper key combos for this.
*** Bug 311330 has been marked as a duplicate of this bug. ***
In addition, I believe the next and previous track bindings of 'Ctrl-Right' and 'Ctrl-Left' contradict the HIG which states they should be 'Alt-Right' and 'Alt-Left'. This would also fix mice with back and forward buttons that gnome also seems to assign these keys to.
*** Bug 167295 has been marked as a duplicate of this bug. ***
From the gtk 2.8.0 release notes: "Changes in the tree view widget The keyboard shortcuts for header reordering and resizing have been changed to (Shift-)Alt-arrows." This could make using Alt-Right and Alt-Left for next track and previous track problematic. Also bug 165716 is related and bug 142378 talk about how most of our key binding have big issues.
Created attachment 60306 [details] [review] add menu items and shortcuts to control volume This adds menu items and shortcuts to control RB's volume, moving in 10% increments. Rating tracks by typing numbers will conflict with type-ahead searching (selecting tracks that start with what you type). I can't find the bug number, but having a "Rate Track" submenu is probably the way to go (potentially with shortcuts like Control-3).
Patch committed to cvs. Retitline bug to reflect remaining request.
Created attachment 80547 [details] [review] Patch to add Ratings Menu item to rate the currently playing song. Patch created against svn 4742. Note: Keybindings were created... Ctrl+Right increases the rating, and Ctrl+Left decreases the rating.
Created attachment 80862 [details] [review] Updated for SVN 4749, Added menus for setting rating from 0-5
Created attachment 80876 [details] [review] Updated for SVN 4749, implemented the way Doc told me to on IRC Sorry about the other patch. It's amazing what the mind will do with no rest, haha.
I don't think it's a great idea to add a whole new menu for this. I'm not quite sure where it should go instead - maybe a sub-menu in the Control menu? I don't really like the idea of using ctrl-left and ctrl-right to modify ratings. Do we really need app-wide shortcuts for this? The problem I have here is that unless the rating column is displayed and the playing song is visible in the track list, there's no feedback to the user indicating that anything actually happened. Being able to modify the rating using keys when a rating widget has focus would be good, though. Some code style issues: - rb_shell_player_rating_cb is not a callback, so it shouldn't be named like one - don't declare variables in the middle of a code block (declaration of 'value' in rb_shell_player_rating_cb) - spaces before function arguments ("function (args)", not "function(args)") - it looks like you're inconsistently using spaces and tabs for indentation - there's not much point clipping score to 0.0 <= score <= 5.0 and then doing 'g_return_if_fail (score >= 0 && score <= 5);'
Jonathan, Thanks for the feedback. I never really thought about the instances where the rating widget wasn't shown. In that case it wouldn't make sense to have app-wide shortcuts, haha. As for this functionality being placed inside of a ratings widget, I like the idea. With the wasted pixels to the right of the "Title by Artist from Album" label and to the left of the volume control button, would we place a ratings widget up there to handle rating songs. This would ensure that whether the ratings were shown in the library view, the user would still be able to know that something happened when they used the keybindings. I'd like to see this happen, but the UI setup for the toolbars, as you know, is vastly different from the UI setup for the menus.
Created attachment 82918 [details] [review] Add ratings widget to header... it's to the left of the elapsed time display Updated for SVN 4829. Add ratings widget to header next to elapsed time widget. Updated code style (tabs, function calls, variable declarations)
Created attachment 82924 [details] [review] Sync the header with the new rating Updated to sync the Header with the new rating. This previously did not happen when using the keyboard bindings.
Created attachment 83518 [details] [review] Show Rating widget in header - 4871 Updated for the current SVN 4871
Created attachment 99961 [details] [review] Updated for latest SVN (5467) Updated to latest SVN (5467) Removed keybindings (as per #11) Removed Ratings menu (as per #11) Changed rb_header_rated_cb to actually update the widget when a song is rated in the browser view.
*** Bug 338990 has been marked as a duplicate of this bug. ***
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/15.