After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 122803 - Conglomerate generates empty pot file name
Conglomerate generates empty pot file name
Status: VERIFIED FIXED
Product: conglomerate
Classification: Other
Component: general
CVS
Other All
: High normal
: ---
Assigned To: conglomerate list
conglomerate list
Depends on:
Blocks:
 
 
Reported: 2003-09-20 12:32 UTC by Christian Rose
Modified: 2009-08-15 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (500 bytes, patch)
2003-09-20 12:35 UTC, Christian Neumair 		none Details | Review

Description Christian Rose 2003-09-20 12:32:02 UTC 
When running "intltool-update --pot" in the po dir of conglomerate to
generate a pot file, the result is named ".pot".

This is a serious problem as there are plenty of good reasons for not
storing generated files such as pot files in cvs but of course we need a
way of reliably generating it then.
Comment 1 Christian Neumair 2003-09-20 12:35:45 UTC 
Created attachment 20133 [details] [review]
Proposed patch.
Comment 2 Christian Neumair 2003-09-20 12:38:27 UTC 
The problem was: intltool-update reads configure.in and uses the
GETTEXT_PACKAGE variable for its POT file. In your version it was
generated at autoconf time, so for configure.in it is an empty variable.
So I simply hardcoded it.

regs,
 Chris
Comment 3 Danilo Segan 2003-09-21 15:32:19 UTC 
Whoops, I've already commited a slightly different patch:
--- configure.in.~1.44.~        Sun Sep 21 16:00:24 2003
+++ configure.in        Sun Sep 21 16:07:27 2003
@@ -23,7 +23,7 @@
 AM_PROG_LIBTOOL
 AC_PROG_INTLTOOL
 
-GETTEXT_PACKAGE=$PACKAGE_NAME
+GETTEXT_PACKAGE=AC_PACKAGE_NAME
 AC_SUBST(GETTEXT_PACKAGE)
 AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE, "$GETTEXT_PACKAGE", [Package name
for gettext])

So, this seems to be the correct way to do it, but I'm not entirely
sure about it.
Comment 4 Danilo Segan 2003-09-21 16:18:08 UTC 
I've build Conglomerate from CVS with these changes, and everything
seems to work just fine (crashes frequently but that doesn't seem
related to this issue; translations are showing up correctly).
Comment 5 Abel Cheung 2003-09-21 19:44:58 UTC 
This really should be fixed in intltool-update.
I've not been able to make it handle all possible cases
of GETTEXT_PACKAGE. So please don't close this bug even
if configure.in is changed with above patch. That would
be a good reminder to fix intltool.
Comment 6 Geert Stappers 2003-09-21 21:32:48 UTC 
It is all ready in CVS. Resolution set to fixed.
BTW: I don't like open bugs on a product for an other product.
Comment 7 Christian Rose 2003-09-21 22:00:17 UTC 
Agreed. deaddog, if you think intltool needs improvement on this area
then open an intltool bug report. You can still link to this bug
report in that new one. But this bug report is about conglomerate's
perviously broken pot file name, not intltools behavior nor anything else.
Comment 8 Abel Cheung 2003-09-22 16:39:23 UTC 
That's fine, I'll open intltool bug later.
Though the root cause is intltool, not conglomerate.
Comment 9 Geert Stappers 2003-10-06 19:29:20 UTC 
closing deaddog favorite bug :-)