GNOME Bugzilla – Bug 121472
"Terminal" for window and tab titles are not translated messages
Last modified: 2004-12-22 21:47:04 UTC
Distribution: Solaris 9 8/03 s9x_u4wos_08b x86 Package: vte Severity: minor Version: GNOME2.3.90 unspecified Gnome-Distributor: GNOME.Org Synopsis: "Terminal" for window and tab titles are not translated messages Bugzilla-Product: vte Bugzilla-Component: VteTerminal Bugzilla-Version: unspecified Description: Description of Problem: gnome-terminal's window title and tab titles are "Terminal" no matter what locales you are. Steps to reproduce the problem: 1. Run a gnome-terminal and see window title is "Terminal". 2. Open new tab and see both tabs titles are "Terminal". 3. Actual Results: Window titles are "Terminal". Expected Results: They should be translated messages for "Terminal", which are to be found in gnome-terminal.mo. How often does this happen? Always. Additional Information: ------- Bug moved to this database by unknown@bugzilla.gnome.org 2003-09-04 13:24 ------- Reassigning to the default owner of the component, nalin@redhat.com.
changing products to g-t.
Created attachment 19743 [details] [review] A proposed patch to use translated messages for defaule title.
The untranslated string comes from the gnome-terminal.schema.in file (as seen by grepping for '\<Terminal\>') It is the name of the default profile. Here is a patch which changes that file; this does not add a new string, since ``Terminal'' is already translated elsewhere.
Created attachment 19746 [details] [review] patch to translate the `Terminal' name of the default profile
Thanks, this looks like a right fix, but it does not seem that gnome-terminal.schemas is built from the .schema.in, so src/Makefile.in should be also patched. Will you please confirm and fix it, too?
Created attachment 19754 [details] [review] A patch for src/makefile.am with this and .schemas.in patch, I've confirmed the proble is fixed.
Nice. You don't really need the intermediate variable; make takes care of that. We do need to wait to after 2.4 is branched off cvs to commit this, if the higher powers agree.
Created attachment 19755 [details] [review] both patches in one
Having gotten RT approval, I've just commited this.
Thanks for the commit. BTW, I'd suggest doing 'cvs remove src/gnome-terminal.schemes'. How do you think?