After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 121011 - Click and hold does not preview in toolbox item selectors, selects instead.
Click and hold does not preview in toolbox item selectors, selects instead.
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
1.x
Other All
: Normal normal
: 2.2
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2003-08-29 15:17 UTC by Simon Kalteis
Modified: 2004-08-05 13:43 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Simon Kalteis 2003-08-29 15:17:02 UTC
Choose e.g. Clone Tool, Open Tool settings dialog, Click on Button
"Pattern" and try to preview an entry other than the one currently selected
by click-and-hold. It won't work, instead it will immediately select the
new (i.e. clicked) entry and close the selector!

This applies to both grid and list view modes.
Comment 1 Sven Neumann 2003-08-31 09:44:27 UTC
This is indeed annoying but it will probably be a nightmare if not
impossible to change this behaviour of the GtkTreeView.
Comment 2 Michael Natterer 2004-08-05 13:26:38 UTC
The popup closes upon selecting an item and the item is selected
upon click. For consistency with popup menus there is no
way this will change.

However, adding the preview functionality to mouse button 2
(which can already be used to drag an item without selecting
it) would be no problem.

I'll look into this.
Comment 3 Michael Natterer 2004-08-05 13:43:59 UTC
Fixed in CVS:

2004-08-05  Michael Natterer  <mitch@gimp.org>

	Enabled previewing items without selecting them in all list and
	grid views using mouse button 2. Implicitly enables previewing of
	items in container popups and thus fixes bug #121011:

	* app/widgets/gimppreview.c (gimp_preview_button_press_event)
	* app/widgets/gimpcellrendererviewable.c
	(gimp_cell_renderer_viewable_clicked): show the preview also on
	mouse button 2 click.

	* app/widgets/gimpcontainertreeview.c
	(gimp_container_tree_view_button_press): dispatch mouse button 2
	clicks to GimpCellRendererViewable, but don't select or change
	anything in the tree_view.

	Unrelated cleanup:

	* app/widgets/gimppreview.c (gimp_preview_button_press_event):
	don't offset bevent->x,y by widget->allocation.x,y before calling
	gimp_preview_popup_show() ...

	* app/widgets/gimppreview-popup.c (gimp_preview_popup_show):
	... instead, do it here generically (check if the parent widget is
	GTK_WIDGET_NO_WINDOW()).