Created attachment 19121 [details] [review]
proposed patch awaiting string freeze breakage permission...

Here are my comments about the patch (although I can't say I'm
experienced with non-unified diff formats):


<property name="label" translatable="yes">GOK Version 0.8</property>

This one is difficult, as it would have to be re-translated in all
translations for every release. A better solution would be to somehow
use %s for the version number.


<property name="label" translatable="yes">Copyright (C) 2001-2003 Sun
Microsystems, 
 Copyright (C) 2001-2003 University of Toronto</property>

This one is also problematic. It doesn't seem to need any translation,
and could benefit from using a proper copyright sign instead (©). I
suggest this message be not marked for translation and a © used instead.


<property name="label" translatable="yes">David Bolter
&lt;david.bolter@utoronto.ca&gt;
> Bill Haneman &lt;bill.haneman@sun.com&gt;
> </property>

Names don't need translation, it would be better to unmark these, and
all other names in this patch, for translation. All UTF-8 characters
are available anyway.


<property name="label" translatable="yes">GOK has also had a lot of
support from:               </property>

The extra spaces at the end of this message seem unnecessary.

Update:
Punting...
The fancy about box will have to wait until 2.6 in my opinion. 
Hopefully gnome-about will be enhanced by then. (bug 80468)  Too many
new strings and UI this late in the game.

adding accessibility keyword

Bill, are we allowed to consider this patch for gok head (prior to Dec
1st deadline)?

dunno what you mean 'allowed to consider'

we're in HEAD, this  is the time for adding stuff.

Keeping an eye on:
http://bugzilla.gnome.org/show_bug.cgi?id=109435

note that 109435 'wont go into 2.4' according to the latest annotation.

Why not apply the existing GOK patch (above)?

Okay, I'll when time permits I'll update it and apply.

Before I forget, I will apply a patch for something else that I think
might work for us.  Having a link to a full credits html page...

Personally I like this better since we are still able to make use of
the  handy gnome_about.  And I see us moving to the gtk+ version when
it is ready...

Created attachment 22068 [details] [review]
proposed patch (I mean't to say "post" not "apply" in my last comment)

Created attachment 22069 [details] [review]
proposed patch - i'm not applying yet

This patch was slightly modified and committed to head.

Closing as per David's last comment.