GNOME Bugzilla – Bug 119270
[HIG] "Esc" should not close keybinding properties dialog
Last modified: 2007-01-06 18:50:17 UTC
As per HIG, in dialog boxes pressing "Esc" key should activate "cancel" button but not "close" button. But in "Shortcuts" capplet (gnome-keybindings-properties) when you press "Esc" it closes the dialog. Steps to reproduce: 1) launch gnome-keybindings-properties 2) Press "Esc" Expected behaviour: since the dialog box contains close button it should not close the window. Actual behaviour: "Esc" closes the shortcuts window
Created attachment 18965 [details] [review] proposed patch
Apologies for spam... marking as GNOMEVER2.3 so it appears on the official GNOME bug list :)
I'm happy to commit this, but I can't find where in the HIG this is listed. Can you tell me what section to look in?
I can't really find this in the HIG either... However, since the other preference pages don't do this and its not "default GTK behavior" anyway, I would say we should apply this patch. If we want "Esc" to close preference pages, property pages, and maybe all windows we should make an HIG change to this effect and get it done everywhere.
Personally I'd rather go the other way and have all of the capplets close on escape.
CC'ing Calum to get his opinion on this bug. Thanks.
This is certainly one that's cropped up before, but when we were writing the HIG, the majority view was that: - Esc should only ever mean Cancel - when present, the OK button should be the default (and therefore activated by Enter) - instant apply windows shouldn't have a default button, so that Enter never activated a Close button (unless the user focused it first). The argument was that it could be confusing if: - pressing Esc sometimes left behind some changes (as would be the case when it meant Close), and sometimes it didn't (as would be the case when it meant Cancel) - Esc was the shortcut for Close, but sometimes Esc was as well. So much so that IIRC gtk was specifically changed so that Esc didn't activate Close buttons any more. The HIG vaguely alludes to this in the Default Buttons section of the Windows chapter, but I agree it makes it far from obvious.
> - Esc was the shortcut for Close, but sometimes Esc was as well. ^^^ Enter
This is a dupe of bug 116045 but all the action is here, so pasting comments from that bug: Opened by merchan@phys.lsu.edu (Gregory Merchan): Escape should only leave a mode or cancel a dialog. The keybindings window is instant-apply (not cancellable) and not modal, so Escape should not close it. -- Additional Comments From Jody Goldberg 2003-06-26 18:31 -- I'd actually prefer the converse. All the capplets should close on Escape
*** Bug 116045 has been marked as a duplicate of this bug. ***
Updating status whiteboard to reflect a11y team's assessment of priority.
Can we decide something about this please? Marking 'High' on account of the patch.
Apologies for spam-- ensuring Sun a11y team are cc'ed on all current a11y bugs. Filter on "SUN A11Y SPAM" to ignore.
so, what's the decision ? Should the capplets be closed or not by Esc ?
Apologies for spam... ensuring Sun a11y folks are cc'ed on all current accessibility bugs.
This has been resolved as per the comments in bug 101293. *** This bug has been marked as a duplicate of 101293 ***