GNOME Bugzilla – Bug 116771
Give draggable items such as topics an icon
Last modified: 2016-09-28 16:06:12 UTC
I've drawn an icon that should indicate to the user that a (text) item can be dragged. This could be useful for instance in the BME Topics list, where the "dragability" is non-obvious. Ideally the icon should be attached to the item "emblem style" or if that's not feasible I'd prefer it to be displayed on the right side of the item instead of on the left. It's unclear to me yet if the same thing should be done with bookmark entries. Some of them already have favicons and it shouldn't become too visually cluttered.
Created attachment 18062 [details] Icon to indicate "dragability" v0.1
Created attachment 18064 [details] 32x32 version of the icon, v0.2. Tell m e which you like better.
hmmm, this just sort of screams "WE NEED A HIG RECOMMENDATION!!!!" :) Reinouts perhaps you should move this bug there?
I has been asked to commenting on dis 'ere bug. People should be able to expect that anything that has an icon on a white background -- e.g. an icon in a Nautilus window, or a bookmark in a bookmarks manager -- is draggable. It shouldn't need any extra decoration. There may be a few cases where dragging is impossible, but it should be *those* which are special-cased -- indicated by a (\) cursor during the drag if they're not draggable at all (e.g. trying to copy a file you don't have read access to), or just by a "spring-back" animation if they're normally draggable but not to the particular place you're trying to drop them (e.g. trying to rearrange items in a list that's always alphabetically sorted). It should not be the stuff that *is* draggable that is special-cased; otherwise the more D&D was fully implemented in Gnome, the more cluttered the UI would get. Therefore, all you need to do to indicate dragability of the BME topics is to add an icon to the left of each of them. I suggested a folder icon; Reinout says this would be wrong because folders can't be nested, but I'm not sure that there's anything about "folder" which says "must be nestable".
Sorry for the spam. Reassigning bugs with a target to our next milestone.
Target 1.2 -> 1.4 due to feature freeze.
Mass-moving Target 1.4 -> 1.6 because of feature and UI freeze. Sorry for the bugspam, search for "mass-move-1.4-1.6" to filter all of it.
Mass reassigning of Epiphany bugs to epiphany-maint@b.g.o
In /usr/share/pixmaps I have a 'documents.png' showing three pieces of paper. This might be a nice, non too intrusive icon to use for a topic. If we can have this, I suggest to close this bug, because it's more a HIG issue than anything else.
Hmm I didn't mean to resolve it immedeately, I must have been tired. Christian, WDYT?
Mass-moving bugs from Target Milestone: 1.6 to 1.8 because of feature, UI and string freeze.
I guess stock_new-labels.png from the hicolor theme would be suitable for a topic. A bookmark without favicon can simply have stock_bookmark.png.
Updating a few fields.
*** Bug 320403 has been marked as a duplicate of this bug. ***
-> 1.12 due to feature and UI freeze.
*** Bug 351098 has been marked as a duplicate of this bug. ***
So we're in freeze again, but if this is an easy fix I doubt the release team would object...
I'll give this one a try.
So I made some advance on this. (All is in reference to 2.14, sorry if that's a problem) So far I discovered that everything happens in ephy-bookmarks-editor.c The function ephy_node_view_add_column() called in line 1856 of this file, one of the parameters is a callback function, it was NULL and i changed it to: provide_topicicon(), this is a function cloned of provide_favicon(). This doesn't work because I decided that it would be easier to try adding a default icon for bookmarks without favicon, so I modified provide_favicon() adding an else: if (icon_location) { pixbuf = ephy_favicon_cache_get (cache, icon_location); } else { GtkWidget *image; image = gtk_image_new_from_stock(GTK_STOCK_OPEN, GTK_ICON_SIZE_MENU); if (GTK_IS_IMAGE (image)) { g_print("holaaaaaaa\n"); pixbuf = gtk_image_get_pixbuf (iimage); } } As the clever ones might note, this doesn't work :), I get a lot of assertion failed errors, I was pointed to use gtk_widget_render_icon() but I don't have any widget in that callback function and I don't think it would be a good idea to create one. Any ideas?
I'm unsure about the whole idea since all topics would have the same one and thus they'd have no function in distinguishing the topics and are just clutter... If you use stock icons, you should use the "stock-id" property on GtkCellRendererPixbuf instead of trying to render the icons yourself.
Nothing is draggable anymore