After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 116178 - flacdec incorrectly finish the decoder at EOS
flacdec incorrectly finish the decoder at EOS
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other All
: Normal normal
: 0.7.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-06-28 11:15 UTC by Munaut Sylvain
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (498 bytes, patch)
2003-10-05 19:29 UTC, Thomas Vander Stichele
none Details | Review

Description Munaut Sylvain 2003-06-28 11:15:01 UTC
When an EOS is encountered ( in the datastream, not an EOS event of
GStreamer), the decoder is finished with a call to
FLAC__seekable_stream_decoder_finish ( line 471 of gstflacdec.c ), and the
flag init is set to TRUE so that when a new stream is given, the decoder
would be re-inited again and the decoding could take place.

Unfortunatly the init flag only make a call to FLAC_..._init and this call
WILL fail because with the finish call, all the options/callbacks have been
resetted. ( If you look at the error code when this init happen, you'll
receive error code 'Callbacks not set' ). So to fix this problem, you can
replace the call to finish with a call to
FLAC__seekable_stream_decoder_reset, and there is no need to set the init
flag to true.

In some cases ( when going from READY to PAUSED, ... ), an init will be
performed on an already inited stream, with no consequence. The call fail
but the decoder is left untouched.
Comment 1 Thomas Vander Stichele 2003-10-05 19:29:25 UTC
Created attachment 20478 [details] [review]
patch
Comment 2 Thomas Vander Stichele 2003-10-05 19:30:12 UTC
patch from Sylvain attached and commited in 0.6.3.1, closing
Comment 3 Ronald Bultje 2003-12-28 21:58:46 UTC
This is required in 0.7.x too.
Comment 4 Ronald Bultje 2004-01-03 23:47:43 UTC
Fixed in HEAD/CVS too...