After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 116077 - [PATCH] sinesrc has problems in waveform
[PATCH] sinesrc has problems in waveform
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.6.x
Other Linux
: Normal normal
: 0.6.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-06-27 03:07 UTC by David Schleef
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
backport to 0.6 (1.60 KB, patch)
2003-08-09 23:27 UTC, David Schleef 		none Details | Review
the correct patch :) (1.33 KB, patch)
2003-08-25 18:24 UTC, David Schleef 		none Details | Review

Description David Schleef 2003-06-27 03:07:39 UTC 
sinesrc creates waveforms that appear to have single-sample errors.
Comment 1 David Schleef 2003-07-24 09:12:59 UTC 
I fixed this, although somewhat poorly, by switching to a simpler and
slower algorithm.  Eventually, I'll fix it to use a better algorithm
than the old one.
Comment 2 David Schleef 2003-08-09 23:27:31 UTC 
Created attachment 19065 [details] [review]
backport to 0.6
Comment 3 David Schleef 2003-08-09 23:28:35 UTC 
Backported patch.  Somebody please check.
Comment 4 David Schleef 2003-08-25 18:24:43 UTC 
Created attachment 19496 [details] [review]
the correct patch :)
Comment 5 Thomas Vander Stichele 2003-08-26 14:35:44 UTC 
can you hear the error ? ie, what goes wrong exactly ?
Comment 6 David Schleef 2003-08-26 16:45:09 UTC 
You can hear pops with the right parameters.  It's very visible if you
dump it to a wav file and look at the waveform.
Comment 7 David Schleef 2003-09-25 00:44:14 UTC 
Applied to 0.6