After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 115996 - configure fails to find Xrandr extension
configure fails to find Xrandr extension
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: METACITY2.6.x
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2003-06-26 06:13 UTC by Ambrose LI
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch to fix the bug (435 bytes, patch)
2003-06-27 04:12 UTC, Ambrose LI
none Details | Review

Description Ambrose LI 2003-06-26 06:13:09 UTC
configure fails to find the Xrandr extension. Checking config.log shows
that   this is caused by it not linking libXrandr together with libXext.

In the non-Solaris case, configure greps $ALL_X_LIBS for -lXext to figure
whether libXext need to be linked. However, it never checks whether there
is a libXext (ALL_X_LIBS is never properly initialized beyond setting it up
to have -lX11), so the check for libXrandr would always fail on a
non-Solaris X11R6.

This applies to both metacity 2.4.55 and 2.5.2.
Comment 1 Ambrose LI 2003-06-27 04:12:51 UTC
Created attachment 17823 [details] [review]
Proposed patch to fix the bug
Comment 2 Rob Adams 2003-07-13 20:32:01 UTC
not sure what you mean.  Configure certainly manages to find randr on
my xfree86 running on debian/i386....
Comment 3 Ambrose LI 2003-07-13 21:29:25 UTC
I guess this is really two bugs in one. Certainly it doesn't occur in
the usual case, since no one else has noticed it (as the previous
comment shows).

First, in *my* system, configure can't find Xrandr. Discussion on
bugzilla.ghostscript.com shows that these links fail because of my
incomplete transition to libc6; i.e., the failures only occur on
systems where the libraries/headers are not in the "usual" places. You
could arguably say that this is the user's problem. But I would say
this will be reproducible if you are transitioning from libc5 to libc6
and have your libraries/headers in the "wrong" places.

However, secondly, the existence of the grepping of -lXext in
$ALL_X_LIBS in configure shows that the intent is certainly that
$ALL_X_LIBS should contain -lXext if it is needed, but the code won't
allow it because $ALL_X_LIBS is never initialized properly. This
certainly is a bug in the code in configure, a failure to initialize a
 variable (namely $ALL_X_LIBS).

The point is that fixing the second sub-bug (the data initialization
error) fixes the first sub-bug. I certainly see the "second sub-bug"
as a real bug.
Comment 4 Rob Adams 2003-07-13 22:35:19 UTC
OK, you've sold me.  I certainly don't see how if could hurt to apply
the patch.  Hopefully Havoc will give his OK soon.
Comment 5 Rob Adams 2003-07-28 02:16:20 UTC
ping
Comment 6 Havoc Pennington 2003-07-28 13:57:04 UTC
I think the "right" fix here is to just add -lXext to the 
AC_CHECK_LIB for Xrandr, next to -lXrender

By "right" I mean "most consistent with the current setup"

However the current setup is pretty clearly a mess.
Comment 7 Rob Adams 2003-08-16 16:05:37 UTC
removing PATCH keyword since the PATCH isn't quite right.
Comment 8 Havoc Pennington 2003-09-29 23:24:08 UTC
Fixed in CVS. Someone ought to clean up all those checks for real, but
not a high priority.