After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 113280 - [0.6.3] Atomic sparc code needs testing
[0.6.3] Atomic sparc code needs testing
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.6.x
Other opensolaris
: Normal critical
: 0.6.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-05-19 13:17 UTC by Benjamin Otte (Company)
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (3.34 KB, patch)
2003-07-29 22:27 UTC, David Schleef 		none Details | Review
patch for 0.6.x (3.12 KB, patch)
2003-07-29 22:36 UTC, David Schleef 		none Details | Review

Description Benjamin Otte (Company) 2003-05-19 13:17:03 UTC 
The sparc code in gstatomic_impl.h requires gcc > 3.1.1

Could somebody with inline assembler knowledge fix those asm volatile stuff
to not use "[var]" constructs please?
Comment 1 David Schleef 2003-05-19 20:57:51 UTC 
Is that "> 3.1.1", ">= 3.1.1", or ">= 3.2".  Not that it matters much,
but I used ">= 3.2".

I frobbed the asm, leaving the original inside an #if, since it's much
cleaner.  Please tell me if it works.
Comment 2 Benjamin Otte (Company) 2003-05-20 13:02:17 UTC 
Sorry, that was supposed to be "gcc >= 3.1"

And I don't know if the locking stuff works. I've had some funky
backtraces after crashes. I don't know if that were your changes. The
default implemntation works a bit better here.

Couldn't we just rip the code of bug 63621 and use that?
Comment 3 David Schleef 2003-05-21 07:24:31 UTC 
Perhaps, but you'd have to upgrade to a sparc64 cpu to use it.
Comment 4 David Schleef 2003-07-29 20:27:33 UTC 
I'm testing on vore.debian.org (sparc64).

gst-launch fakesrc ! tee ! fakesink tee0.src1 ! fakesink

fails almost immediately.
Comment 5 David Schleef 2003-07-29 22:26:45 UTC 
Fixed and tested in HEAD.  The code was obviously wrong (to one who
understands sparc asm).  Needs backporting.
Comment 6 David Schleef 2003-07-29 22:27:46 UTC 
Created attachment 18735 [details] [review]
patch
Comment 7 David Schleef 2003-07-29 22:36:58 UTC 
Created attachment 18737 [details] [review]
patch for 0.6.x
Comment 8 Ronald Bultje 2003-08-03 20:52:37 UTC 
Applied to 0.6.3. Thanks. :).