After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 112172 - Get rid of VteReaper
Get rid of VteReaper
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.11.x
Other All
: Normal minor
: ---
Assigned To: VTE Maintainers
VTE Maintainers
[fixed-next]
Depends on: 398862
Blocks: vte1.0
 
 
Reported: 2003-05-03 21:17 UTC by Gustavo Giráldez
Modified: 2014-03-24 21:13 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
vte patch (4.03 KB, patch)
2006-04-12 08:49 UTC, Behdad Esfahbod
rejected Details | Review
g-t patch (2.02 KB, patch)
2006-04-12 08:49 UTC, Behdad Esfahbod
rejected Details | Review
[PATCH] Das Terminal und der Tod. Bug #112172. (21.12 KB, patch)
2008-06-26 19:34 UTC, Christian Persch
none Details | Review

Description Gustavo Giráldez 2003-05-03 21:17:06 UTC
The singleton object VteReaper should be moved to some base library such as
libgnome.  The reason for this request is two-fold:

a) the object grabs the SIGCHLD signal and reaps all the process children
making it impossible to get such notification without connecting to the
reaper (the signal handler could be replaced, but that would break the Vte
widget)

b) once the singleton has been created it cannot be destroyed, thus making
the use of vte for a plugin impractical

These problems were found while playing with the plugins in anjuta2.  More
specifically, because of b) the terminal plugin cannot be unloaded
dinamically; and because of a) the project backend plugin cannot tell when
the script it uses to modify automake projects has exited.

Having VteReaper in a base library makes it possible for all the components
of an application be able to get SIGCHLD notifications, and it's very
unlikely that a base library will need to be unloaded.
Comment 1 Kjartan Maraas 2005-01-05 00:12:33 UTC
There's a copy in gnome-control-center as well, another argument for moving it.
Comment 2 Behdad Esfahbod 2006-04-12 08:49:09 UTC
Created attachment 63289 [details] [review]
vte patch
Comment 3 Behdad Esfahbod 2006-04-12 08:49:38 UTC
Created attachment 63290 [details] [review]
g-t patch
Comment 4 Behdad Esfahbod 2006-04-12 10:32:48 UTC
Ah, attached patches to wrong bug.  Please ignore.
Comment 5 Behdad Esfahbod 2006-05-22 16:29:09 UTC
Anyone willing to submite a patch to move this to glib?
Comment 6 Behdad Esfahbod 2007-11-27 12:59:21 UTC
So, we can simply get rid of it and use g_child_watch_add() instead.
Comment 7 Behdad Esfahbod 2007-11-27 13:16:55 UTC
In fact with glib >= 2.4.0 (which vte requires anyway), VteReaper becomes a wrapper around g_child_watch_add().
Comment 8 Christian Persch 2008-06-26 19:34:18 UTC
Created attachment 113485 [details] [review]
[PATCH] Das Terminal und der Tod. Bug #112172.

 doc/reference/tmpl/reaper.sgml |   25 ---
 doc/reference/vte-docs.sgml    |    2 -
 doc/reference/vte-sections.txt |   17 --
 doc/reference/vte.types        |    2 -
 src/Makefile.am                |   18 +--
 src/reaper.c                   |  327 ----------------------------------------
 src/reaper.h                   |   64 --------
 src/vte-private.h              |    3 +-
 src/vte.c                      |  129 +++++++---------
 9 files changed, 59 insertions(+), 528 deletions(-)
Comment 9 Behdad Esfahbod 2008-06-27 13:30:49 UTC
Looks good.  Are you planning to break API this cycle?  That would be a good idea and we can even call it 1.0 after an API review.
Comment 10 Christian Persch 2008-06-27 16:26:20 UTC
I guess it's a bit late in the cycle to get all the want-1.0's in. Let's try for 2.26 ?
Comment 11 Behdad Esfahbod 2008-06-27 17:15:27 UTC
Sounds good.  Feel free to branch for 2.24 already.
Comment 12 Robert Ancell 2009-05-08 04:17:55 UTC
ping.  Can this be applied in 2.27?
Comment 13 Christian Persch 2009-05-08 12:00:34 UTC
This is scheduled for vte 1.0. I'm not sure however 2.28 will see 1.0.

Do you have a particular need for this patch?
Comment 14 Robert Ancell 2009-05-10 23:30:11 UTC
No particular need, just pushing patches that are being carried by Ubuntu.  On closer look the Ubuntu patch seems to be related to adding VteReaper Python support..