GNOME Bugzilla – Bug 111906
custom actions don't appear in the toolbar overflow menus.
Last modified: 2004-12-22 21:47:04 UTC
Yeah we need to implement them in ephy-bookmark-action and ephy-topic- action. It should not be too hard.
ephy-go-action, ephy-location-action and ephy-spinner-action too.
Created attachment 16174 [details] [review] Initial stab at working this out
Guys, I've taken an initial stab at a patch for this. I appreciate it's not yet tidy! So far I've got the menu items to appear - but nothing happens when I select them (And I get a *load* of errors on the terminal output). If you can give me some pointers I'm happy to work on this and get it into a useable state[1] - let me know what you think ....
I dont think you need to do this, eggaction will do it for you I think. It would seem you can just override create_menu_item and do something like this in it: GtkWidget *menu_item; menu_item = (* EGG_ACTION_GET_CLASS (action)->create_menu_item) (action); set_label etc ... You could also avoid to call the parent method and create the menu item yourself... it would work anyway but maybe this is cleaner.
marco i think to get this working we need to convert our custom action into egg_tool_items so that we can over the create_menu_proxy function.
as a side note, i do think it would be kind of cool to implement a custom menu entry for the address entry so that when its in the menu you can still enter in addresses.
I think eggmenu create eggtoolitems ... not sure though, need to check.
Created attachment 17468 [details] [review] Implement overflow menu item for bookmarks
Toolbar overflow menu items are now implemented for bookmarks, bookmark topics, the zoom control and the go button. The spinner and the location entry _never_ overflow (the spinner because it's pack_end, and the location entry because it's expandable).