After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 111026 - Window-menu applet does not look like a menu
Window-menu applet does not look like a menu
Status: RESOLVED DUPLICATE of bug 160450
Product: gnome-panel
Classification: Other
Component: window selector
unspecified
Other other
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-04-17 14:48 UTC by Vincent Noel
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot showing the difference (38.47 KB, image/png)
2004-05-14 13:54 UTC, Vincent Noel
  Details
patch following Ronald's instructions (2.00 KB, patch)
2004-10-26 22:25 UTC, Vincent Noel
needs-work Details | Review
new patch (3.31 KB, patch)
2004-10-26 22:33 UTC, Vincent Noel
accepted-commit_now Details | Review
screenshot with the patch (16.04 KB, image/png)
2004-10-26 22:36 UTC, Vincent Noel
  Details

Description Vincent Noel 2003-04-17 14:49:02 UTC
Package: gnome-panel
Severity: minor
Version: GNOME2.3.0 2.3.0
os_details: Gnome.Org
Synopsis: Window-menu applet does not look like a menu
Bugzilla-Product: gnome-panel
Bugzilla-Component: Window Menu Applet
Description:
Description of Problem:
The window menu applet does not look like a menu when you click on it.

Steps to reproduce the problem:
1. Click on the window menu applet.

Actual Results:
The applet (the button itself you just clicked on) does not look like a
regular menu item, rather like a button.

Expected Results:
Once clicked on, the applet should look like a regular menu item, just
like the "menu bar" applet does. This would
look a lot more consistent, as the name of the applet is "window menu".




------- Bug moved to this database by unknown@bugzilla.gnome.org 2003-04-17 10:49 -------

The original reporter (vnoel@cox.net) of this bug does not have an account here.
Reassigning to the exporter, unknown@bugzilla.gnome.org.
Reassigning to the default owner of the component, gnome-panel-maint@bugzilla.gnome.org.

Comment 1 Kjartan Maraas 2003-06-17 13:58:28 UTC
Are you talking about the window list? The applet showing the
currently running applications - also known as the tasklist? That's
called the tasklist, not window menu list. If you're thinking about
the panel-menu applet that's not being distributed any longer I think.
Comment 2 Vincent Noel 2003-06-17 14:27:10 UTC
I am referring to the applet that looks like a menu with a small icon
of the running application in it, and when clicked pops up a list of
active windows. Before gnome-panel 2.3 it was part of the foobar
panel, on the extreme right (its still like that in XD2). 
Since gnome-panel 2.3 it is a seperate applet, called "window menu".

According to its name, this applet is a menu and behaves like one, but
its look is not consistent with other menus (when you click it).

I can provide a screenshot if you want...
Comment 3 Vincent Untz 2003-09-23 15:15:23 UTC
Vincent: what do you mean by "not consistent" ?
Comment 4 Vincent Untz 2004-03-07 14:30:09 UTC
Vincent: could you answer the question? Thanks
Comment 5 Vincent Noel 2004-03-07 17:58:52 UTC
By "inconsistent", I mean that when you click the applet, it does not
look the same as a regular clicked menu item (not the same color,
etc)... For example click on the main menu applet : it looks as any
other menu. It just looks strange as both applets behave like menus,
so they should look the same.

However, now that the applet is a "window selector" and not
"window-menu", maybe this is not a problem anymore.
Comment 6 Vincent Noel 2004-05-14 13:54:46 UTC
Created attachment 27699 [details]
screenshot showing the difference

I have attached a screenshot showing the unconsistency between
the window-selector applet and other, regular, menus.
Comment 7 Vincent Noel 2004-07-01 20:33:06 UTC
What additional info do you need ?
Comment 8 Mark McLoughlin 2004-08-06 16:52:02 UTC
Nice screenshot :-)
Comment 9 Vincent Noel 2004-08-06 17:02:41 UTC
I've tried to implement a "normal" menu behavior, by turning the applet button
into a gtk_menu_item, but when there is no label in the gtk_menu_item the icon
appears weird... Other than that it almost works.
Comment 10 Vincent Noel 2004-08-10 15:11:42 UTC
Note that a similar bug exists for the mixer applet (bug 98355).
Comment 11 Ronald Bultje 2004-10-26 14:28:25 UTC
Vincent, I just fixed the mixer thing and I'll fix this too... If only you can
tell me where I find the sources? I can't find the window selector applet
sources in gnome-applets CVS.
Comment 12 Vincent Untz 2004-10-26 14:34:42 UTC
Ronald: it's in gnome-panel/applets/wncklet/
Comment 13 Ronald Bultje 2004-10-26 14:57:13 UTC
Ah, thanks. No patch then, yet. But here's a description of a patch. :-p. You
need two changes in gnome-panel/applets/wncklet/window-menu.c.

in window_menu_menu_hidden(), delete the line gtk_frame_set_shadow_type
(GTK_FRAME (window_menu->frame), GTK_SHADOW_NONE); and change it to
gtk_widget_set_state (GTK_WIDGET (window_menu->frame), GTK_STATE_NORMAL);,

in window_menu_popup_menu(), delete the line gtk_frame_set_shadow_type
(GTK_FRAME (window_menu->frame), GTK_SHADOW_IN); and change it to
gtk_widget_set_state (GTK_WIDGET (window_menu->frame), GTK_STATE_SELECTED);

You can basically remove the whole frame and use window_menu->applet instead,
since the only reason that the frame exists is to have a relief-effect when the
applet is selected. Since that touches quite a bit of code, I suppose you'll
want me to prepare a patch either way.

If you need more than just words, I'll download CVS and prepare a patch, that'll
take me a few days, though.
Comment 14 Vincent Noel 2004-10-26 22:25:48 UTC
Created attachment 33094 [details] [review]
patch following Ronald's instructions

Following Ronald's instructions (thanks !), here is the relevant patch.
It fixes this bug, somehow...

... however (unfortunately) the widget "selected" color is not the same as a
regular menu :( It's a different shade. This is also true for the mixer applet.
Comment 15 Vincent Noel 2004-10-26 22:33:08 UTC
Created attachment 33095 [details] [review]
new patch

With the previous patch, a thin 1-pixel line appeared around the window menu
applet when selected.

This new patch implements the dirty clock-applet trick (sorry, but there's no
better way it seems) to remove the focus line. See bug 147999 (which recommends
to apply this trick to other applets as well... when it's useful).

The applet looks nice with this patch.
Comment 16 Vincent Noel 2004-10-26 22:36:04 UTC
Created attachment 33096 [details]
screenshot with the patch

This screenshot shows how the applet looks with the patch (with industrial
theme).
Notice the slight color difference between the applet background and the
selected item in the window menu... But I'm not sure if that's really important
anyway.
Comment 17 Vincent Untz 2004-10-27 08:17:25 UTC
Comment on attachment 33095 [details] [review]
new patch

I suppose you tested it and it works well. Please commit :-)
Comment 18 Ronald Bultje 2004-10-27 08:59:01 UTC
As for the colour difference: I didn't note it on my computer (menu and select
are the same colour here), but I'm sure that we can work that out later on.
Maybe we should ask the Gtk+ guys if there's a special state or something else
for menu-colour?
Comment 19 Vincent Noel 2004-10-27 13:20:51 UTC
Committed. Thanks Ronald :)
Now I'd like to see this effect in all applets that open an extra pane ;-)
Comment 20 Vincent Untz 2004-10-27 13:33:52 UTC
Vincent: I think it'd be better to open bugs for the other applets and close
this one (except if you want to keep it open for the colour problem).
Comment 21 Vincent Noel 2004-10-27 14:46:55 UTC
Yeah, of course, that's what I meant.
I think we can keep this open for the color thing...
Comment 22 Vincent Untz 2004-11-29 13:48:38 UTC
This might be a stupid question... but why aren't we using a menu widget?
Comment 23 Vincent Untz 2004-12-05 11:02:14 UTC
We now have a patch to use a menu bar.

*** This bug has been marked as a duplicate of 160450 ***