Bug 110799 – Crash in articles_are_valid() when article_qty==0

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 110799 - Crash in articles_are_valid() when article_qty==0


Summary:	Crash in articles_are_valid() when article_qty==0


Status:	RESOLVED FIXED

Product:	Pan
Classification:	Other
Component:	general
Version:	pre-0.14.0 betas
Hardware:	Other All

Importance:	Normal critical
Target Milestone:	0.14.0
Assigned To:	Charles Kerr
QA Contact:	Pan QA Team

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2003-04-14 23:27 UTC by Charles Kerr
Modified:	2006-06-18 05:11 UTC

See Also:
GNOME target:	---
GNOME version:	---

Description Charles Kerr 2003-04-14 23:27:57 UTC

articles_are_valid() dereferences articles[0] even when the article_qty is 0.
This can cause a crash when, for example, hitting the 'D' key, to add
subthreads to the selection, when no articles are selected.

+ Trace 35935

#0 articles_are_valid_in_group
at article.c line 1010
#1 article_get_unique_threads
at article.c line 582
#2 add_to_selection_nolock
at articlelist.c line 409
#3 articlelist_add_replies_to_selection_nolock
at articlelist.c line 430

Comment 1 Charles Kerr 2003-04-14 23:41:37 UTC

Fixed in CVS:

http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan/base&command=DIFF_FRAMESET&file=article.c&rev1=1.77&rev2=1.78&root=/cvs/gnome
http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan&command=DIFF_FRAMESET&file=ANNOUNCE.html&rev1=1.124&rev2=1.125&root=/cvs/gnome