After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 109480 - workspace width in the applet not proprotional to actual workspace size
workspace width in the applet not proprotional to actual workspace size
Status: RESOLVED FIXED
Product: libwnck
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libwnck maintainers
libwnck maintainers
Depends on:
Blocks:
 
 
Reported: 2003-03-29 07:48 UTC by Arvind S N
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch fixes the problems (3.05 KB, patch)
2003-03-29 07:49 UTC, Arvind S N 		none Details | Review
Reworked patch based on Havoc's comments. (2.87 KB, patch)
2003-04-04 06:12 UTC, Arvind S N 		none Details | Review

Description Arvind S N 2003-03-29 07:48:48 UTC 
On a multihead setup with different depths we have the following issues,

a) The workspace size (width) in the applets-workspace-switcher is not
   proportional with real workplace size

b) The Netscape icons are viewable on applets-workspace-switcher of primary
   screen, but not on secondary.
Comment 1 Arvind S N 2003-03-29 07:49:31 UTC 
Created attachment 15294 [details] [review]
Patch fixes the problems
Comment 2 Havoc Pennington 2003-03-29 16:40:50 UTC 
Can you use temporary variables to avoid making this statement so long:

height_ratio = (double) workspace_rect->height / (double)
gdk_screen_get_height (
+                                                                    
    _wnck_screen_get_gdk_screen (
+                                                                    
     wnck_window_get_screen(window)));
   
Or alternatively, you could add _wnck_window_get_gdk_screen() perhaps.

Looks like a good fix other than that.
Comment 3 Arvind S N 2003-04-04 06:12:36 UTC 
Created attachment 15453 [details] [review]
Reworked patch based on Havoc's comments.
Comment 4 Havoc Pennington 2003-04-04 06:52:33 UTC 
Thanks, fixed in CVS now. (The aspect ratio patch is slightly different 
due to the bug #109654 changes, but the effect is the same, 
problem should be fixed.)