After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 108337 - fontmap doesn't take care of .ttc files
fontmap doesn't take care of .ttc files
Status: RESOLVED FIXED
Product: gnome-print
Classification: Deprecated
Component: general
2.2.1
Other Linux
: Normal normal
: ---
Assigned To: Chema Celorio
Chema Celorio
: 103856 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-03-13 19:45 UTC by Akira TAGOH
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix patch (629 bytes, patch)
2003-03-13 19:46 UTC, Akira TAGOH
none Details | Review
fixes the handling of the multiple faces (2.17 KB, patch)
2003-03-14 17:40 UTC, Akira TAGOH
none Details | Review
updated patch (contains second patch and supporting the TTF embed code) (5.32 KB, patch)
2003-03-14 20:53 UTC, Akira TAGOH
none Details | Review

Description Akira TAGOH 2003-03-13 19:45:32 UTC
gnome-fontmap.c is just missing the check of .ttc extension.
Comment 1 Akira TAGOH 2003-03-13 19:46:05 UTC
Created attachment 15003 [details] [review]
fix patch
Comment 2 Chema Celorio 2003-03-13 20:06:10 UTC
I think the problem is not that the fontmap is not loading it but that
gnome-print can't parse them. I tried adding the extension to the
fontmap but gnome-print couln't parse them, I opened bug 103856 for it.
Comment 3 Akira TAGOH 2003-03-14 15:52:44 UTC
Yeah, gnome-print has the handling of face issue for TrueType font.
but gnome-print won't handles even face 0 in .ttc without this patch.
at least it should be needed.
Comment 4 Chema Celorio 2003-03-14 16:03:26 UTC
I don't think gnome-print can't even handle face 0 at this point,
which is why a larger patch is needed. Have you tested and embeded a
.ttc in a PS or PDF job?
Comment 5 Akira TAGOH 2003-03-14 16:35:55 UTC
Yeah. I've tested this with gedit. actual problem is
gnome_font_family_list() doesn't return the fontname in .ttc files,
because it's ignored since fcpattern_to_gp_font_entry() returns NULL
for unknown extension.
Comment 6 Akira TAGOH 2003-03-14 17:38:56 UTC
Okay. I made a patch to fix the handling of multiple faces.
Comment 7 Akira TAGOH 2003-03-14 17:40:56 UTC
Created attachment 15023 [details] [review]
fixes the handling of the multiple faces
Comment 8 Chema Celorio 2003-03-14 18:47:08 UTC
*** Bug 103856 has been marked as a duplicate of this bug. ***
Comment 9 Akira TAGOH 2003-03-14 20:52:36 UTC
updated patch will also supports the TTF embed code. when I tested
that with Japanese TTC file, I got three warnings like "Too big table
in font". I think it means gnome-print could read 'glyf' table,
because basically TTF for CJK always gets this warning right now.
Unfortunately I have no TTC except for CJK. so someone needs to test
gnome-print, which applies first patch and updated patch anyway.
Comment 10 Akira TAGOH 2003-03-14 20:53:48 UTC
Created attachment 15032 [details] [review]
updated patch (contains second patch and supporting the TTF embed code)
Comment 11 Kjartan Maraas 2003-06-14 14:39:26 UTC
Can this go into 2.2.x?
Comment 12 Murray Cumming 2003-09-23 15:30:04 UTC
By adding a field to the _GPFontEntry struct, this seems to break the
API and ABI. Am I wrong?
Comment 13 Akira TAGOH 2003-09-23 18:01:33 UTC
Yes or no. because basically nobody can't access GPFontEntry itself
directly so that it's a closed structure. and changing the number of
arguments for gp_tt_split_file() should be no problem so that it's
also a closed API. so I think this changes is globally no API changes
and there are ABI breakage, but it shouldn't be affected. I think
soname should be bumped to be safe, though.
Comment 14 Andreas J. Guelzow 2003-11-27 06:44:14 UTC
Akira,

do you have a changelog patch for the last patch attached to this report?
Comment 15 Andreas J. Guelzow 2003-11-28 05:32:07 UTC
patch committed to cvs HEAD (post 2.5.0.1)

we will see haow many complaints we get about the slight interface changes