GNOME Bugzilla – Bug 108143
Should be able to open all bookmarks in a topic at once
Last modified: 2004-12-22 21:47:04 UTC
Currently, if you select several bookmarks and choose "Open in new tab" from the context menu, they all open nicely in a set of tabs. This is useful for reading daily comics or news, and would be easier to do with a context menu for the topics pane of the Bookmarks dialogue. Perhaps this could also be used if/when topics are draggable to toolbars.
the more i think about i'd rather we not add open to the topics context menu. Conceptually its slightly wierd (since you can't open a topic really, its metadata not a folder). Also we now have select all in the menu, which makes opening all the bookmarks in a topic trivial. edit -> select all file -> open in new tabs/windows
I'm not suggesting that the context menu for topics should have an entry labelled "Open". Something like "Open all bookmarks" would be perfectly clear, surely. To give some context: I have all my most frequently accessed sites bookmarked. For example, News, Comics, Weblogs, and so on. I often want to read all my favourite comics, which obviously involves reading all the bookmarks in the Comics topic. Use case: Open bookmarks editor Right-click "Comics" topic Choose "Open all bookmarks" (Even better, when topics are draggable to toolbars, right-click "Comics" topic on the toolbar, choose "Open all bookmarks".) With your "trivial" method: Open bookmarks editor Left-click "Comics" topic Click in right-hand pane (otherwise "Select All" selects all topics?) Open Edit menu Choose "Select All" Open File menu Choose "Open in New Tabs" That seems (a) more convoluted and (b) less discoverable than my proposal.
I agree with Dave here. With keybindings you can do it pretty fastly. I dont think this task has enough priority to require a special menuitem.
I've been hacking on this today, adding as a attachment. Waiting for review from marco before committing
Created attachment 15584 [details] [review] diffed with -w, eg no whitespace changes.
Some style things. if { } should be if { } All if should have {} also for 1 line. Instead of creating tab/window manually you can use ephy_shell_new_tab, it will deal with tab pref. Last thing is it necessary to show a confirm dialog for windows ? It's what user is requesting after all ... Personally I'd stop to use the feature if I'd have to go through a confirm dialog. Maybe we should keep the dialog only for a big number of windows (and big number of tabs too maybe). CCing dave to see what he thinks.
Ouch. Johan please use tabs instead of white spaces in the code you add. I'm sorry but having to type all spaces in vim slow down me really too much :/
Questions and comments: 1. I assume that any menus we are discussing are bookmark toolbar only right? as we agree no new menus in the bme... 2. bm toolbar is a pretty hacker feature. It isn't accessible, obvious etc. It's basically a hidden feature. With that said, will users of the bookmark toolbar ever want to open all the bm's in a topic in anything but tabs? 3. Confirmation dialogs are pretty evil and you inevitably end up having some requesting one of those horrendous "Don't ask me again" check boxes. So yeah see number 2.
I sort of like 2. I'd go for "Open in tabs" if we cant avoid the confirm dialog.
OT I guess we should have an accessible way to add bookmarks to toolbars at some point. I guess pick up could work.
Created attachment 15608 [details] [review] v2: Style changes and upped 2 to 10. This needs more discussion.
I know I've seen a smiliar dialog to the one I've added in this patch, in nautilus. Maybe we should try to use the same constants (for number of windows). Or just remove it in favor of only tabs.
My opinion is that we should go for just tabs
Marco, if I change so it always open in tabs, is it okay to check in?
Would a context menu on the button be better as oppose to an appended menu? It thought we we're going to add this for removal of topics and bm's from the bookmark toolbar, but maybe that has changed?
I'm a bit worried by the behavior of replacing current tabs. Ihmo this is totally unexpected :/ Dave ? About the context menu ... Do you think we should have it also in non editing mode ?
Please, no more context menus :) Isn't it better to use existing menus for this instead? And about replacing the current tabs, Marco. I was a bit sceptical about this in the beginning, but as soon as you get used to it. If we don't replace the tabs, the user have to close lots of tabs if he use this in more than one topic. I normally use it like this (and think that most other will use it in the same way): I have different topics, News, Diaries, Computer-News etc. In them I have 5-10 bookmarks. I start by clickin on the news topic, and open all in tabs, I read everything in all the pages, then I go to the Diaries section and do the same. If it wouldn't replace the tabs, I would be forced to close all the tabs first, before selection this. Which is non optimal in the long run. Btw, this is exactly how phoenix behaves.
*** Bug 113279 has been marked as a duplicate of this bug. ***
*** Bug 124777 has been marked as a duplicate of this bug. ***
I wanted to add a suggestion here after speaking with daveb on irc, as I asked exactly about this feature which after finding it hidden was so great for me... So what about the possibility of makingthe category itself clickable so that one doesn't need to select all the URLS he wants to open under a category and then open them but simply go to the bookmarks editor, and click the category and all the URLs listed under will open.
many users check on a daily basis 4 websites and more so making this option not hidden will make the users use it and it is a great addition to the browser as I think noe one wants to type on a daily basis 10 urls like I do ;)
>making the category itself clickable Do you mean double click on category opens all bookmarks in tabs ? It would seem too easy to trigger it by mistake to me.
How about this: if there's a topic selected (left pane), but no bookmark selected in the right pane, "Open In New Tab/Window" opens all the bookmarks in the topic in new tabs (of the existing window/of a new window). That way an accidental double-click won't open loads of tabs, but the feature's still easily accessible.
I think the inconsistency would be very annoying in a number of ways. In general I think it's not a good idea to make a browse mode treeview behave like a list of items. If we really have to support something like this I think a context menu or similars would be much better.
I'd rather go with jdahlin approach here, with the exception that I would not "overwrite" all open tabs but just the currently selected one. Safari has a similar interface, not sure about how it "overwrites" though, would be good to check.
I still believe (for a number of reasons) that it's better to overwrite existing tabs rather than create new ones. (Like Firebird/Mozilla does)
These are pro/cons as I see them. Pro of "overwriting" all tabs: - You avoid to have to create a new window to open a group of tabs in Cons - It's not intuitive - It can cause data loss In my opinion avoiding a ctrl+n in an already fast operation like openinf several tabs is not worth the problems it cause. Dave ?
I agree with marco, we should most definately not overwrite existing tabs/windows that plain wrong.
Comment on attachment 15584 [details] [review] diffed with -w, eg no whitespace changes. Marking obsolete attachments in open bugs.