GNOME Bugzilla – Bug 107979
jhbuild should install the hicolor icon theme from freedesktop.org
Last modified: 2004-12-22 21:47:04 UTC
http://www.freedesktop.org/standards/icon-theme-spec.html gnome-icon-theme is meant to depend on this.
Should we ask freedesktop.org to make the default-icon-theme package easier to install automatically, or should we extend jhbuild to allow it to edit the Makefile?
Is there any reason we can't just pass PREFIX=prefix to each make install? Anything created by auto* should be quite happy with this, I believe...
Tom: the problem isn't just passing a variable to "make". The problem is that the build process differs from all the other packages we currently handle, so would require some specialised code (which is not in itself difficult). The build process is roughly: wget http://freedesktop.org/Software/icon-theme/releases/hicolor-icon-theme-0.2.tar.gz tar xzf hicolor-icon-theme-0.2.tar.gz make PREFIX=/... Anyway, I'd prefer to get jhbuild-ng merged first, since it makes a number of changes to the build engine.
*** Bug 134070 has been marked as a duplicate of this bug. ***
Would it be possible to add a comment in the README that this package is required? It took me a little bit of searching to track it down... (For some reason I was unable to read earlier today when I searched the bug list and missed this one.)
I'd like to fix it properly, actually, rather than just telling the user to install it manually beforehand. Bumping priority because gnome-icon-theme build errors out if hicolor-icon-theme is not found now. Probably the best solution for this is to add a minimal autoconf setup to the module so that the standard configure/make/make install combo works.
Sent an email to Alex with a patch to convert hicolor-icon-theme over to using autoconf to build. If he accepts the patch, this bug will be extremely simple to resolve.
Heh, I just sent a patch to xdg-list to do exactly the same thing. Oh well :-)
Your patch looks quite similar to mine (although it doesn't look like "make dist" would work quite right). Hopefully Alex will accept one of them ...
Alex just released this package: http://freedesktop.org/Software/icon-theme/releases/hicolor-icon-theme-0.4.tar.gz I'll patch jhbuild to handle it tonight.
jhbuild now lists hicolor-icon-theme as a dependency for gnome-icon-theme for the gnome24 and gnome26 module sets. Marking fixed.
The URL field has been removed from bugzilla.gnome.org. This URL was in the old URL field, and is being added as a comment so that the data is not lost. Please email bugmaster@gnome.org if you have any questions. URL: http://www.freedesktop.org/Software/icon-theme