After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 107729 - Bonobo IDL should use #ifndef in preference to #if !defined()
Bonobo IDL should use #ifndef in preference to #if !defined()
Status: RESOLVED FIXED
Product: bonobo
Classification: Deprecated
Component: libbonobo
1.0.x
Other All
: High normal
: ---
Assigned To: Michael Meeks
Luis Villa
Depends on:
Blocks:
 
 
Reported: 2003-03-06 14:47 UTC by bill.haneman
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to Bonobo.idl and Bonobo_Property.idl to fix this bug. (1.86 KB, patch)
2003-03-06 14:52 UTC, bill.haneman 		none Details | Review

Description bill.haneman 2003-03-06 14:47:32 UTC 






Comment 1


bill.haneman





          2003-03-06 14:49:19 UTC
        



Some IDL compilers (well, idlj anyhow) can't deal with constructs like

#if !defined(__FOO_) && defined(__BAR__)

but #ifndef / #ifdef are fine.

Currently this has been fixed for a number of bonobo IDL files but
some still use the more complex construction.  This blocks
monkeybeans2.  Fortunately the patch is simple and has precedent.  I
will attach a patch.







Comment 2


bill.haneman





          2003-03-06 14:52:48 UTC
        



Created attachment 14815 [details] [review]
patch to Bonobo.idl and Bonobo_Property.idl to fix this bug.






Comment 3


Elijah Newren





          2003-03-07 00:03:14 UTC
        



Adding PATCH keyword (& bugsquad keyword), and setting priority->high
because of the patch.






Comment 4


Michael Meeks





          2003-03-07 01:55:43 UTC
        



Looks fine - please can you commit to HEAD and gnome-2-2 ( and
gnome-2-0 if you're particularly keen :-)






Comment 5


bill.haneman





          2003-03-07 12:10:19 UTC
        



fixed in HEAD, pending putback to gnome-2-2.






Comment 6


bill.haneman





          2003-03-07 12:21:36 UTC
        



fixed in gnome-2-2 branch also.. THanks to all.