After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 106242 - qif Importer should warn users about dates before 1970
qif Importer should warn users about dates before 1970
Status: VERIFIED FIXED
Product: GnuCash
Classification: Other
Component: Import - QIF
git-master
Other Linux
: Normal normal
: ---
Assigned To: Derek Atkins
Derek Atkins
: 113880 128621 134473 (view as bug list)
Depends on:
Blocks: backport
 
 
Reported: 2003-02-16 18:36 UTC by Glenn English
Modified: 2018-06-29 20:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.48 KB, patch)
2008-01-13 10:12 UTC, Charles Day 		committed Details | Review
QIF demonstrating the bug (133 bytes, text/plain)
2008-01-13 10:13 UTC, Charles Day 		  Details

Description Glenn English 2003-02-16 18:36:46 UTC 
When importing qif, the importer handles dates later than 1/1/1970 only.
Earlier than that crashes the import process and the main program.

For those of us of a certain age, a loud warning in the first import druid
window would be helpful.

Or better yet, fix the importer.
Comment 1 Christian Stimming 2003-02-18 12:25:29 UTC 
Do you think you can submit a sample QIF account file? It should be
sufficient if it contains only one data set with that specific date.
That way, the developers can easily reproduce your problem, and it is
much more likely to be fixed soon. Thanks.
Comment 2 Derek Atkins 2003-05-25 03:32:50 UTC 
Oh, this problem is easily reproducible, so don't worry about
supplying a data file.  I've changed the summary to be more accurate.
Comment 3 Derek Atkins 2003-06-11 14:51:15 UTC 
*** Bug 113880 has been marked as a duplicate of this bug. ***
Comment 4 Derek Atkins 2003-06-11 14:51:47 UTC 
I'll take ownership
Comment 5 Jon Lapham 2003-08-15 17:29:20 UTC 
Derek-  is this a documentation bug?  If no, can we change the
component to something else?
Comment 6 Derek Atkins 2003-08-15 20:09:43 UTC 
Yes, it should be documented, but it's not _just_ a documentation bug.
 GnuCash should not crash when fed dates prior to Jan 1, 1970, so
there is a real bug in the code.
Comment 7 Derek Atkins 2003-12-06 15:25:39 UTC 
*** Bug 128621 has been marked as a duplicate of this bug. ***
Comment 8 Derek Atkins 2004-02-16 04:16:28 UTC 
*** Bug 134473 has been marked as a duplicate of this bug. ***
Comment 9 Christian Stimming 2006-08-04 09:09:58 UTC 
I guess this issue still applies to the current SVN code... Derek?
Comment 10 Derek Atkins 2006-08-04 13:27:46 UTC 
Yeah, it still does.
Comment 11 Charles Day 2008-01-13 10:12:43 UTC 
Created attachment 102718 [details] [review]
Proposed patch

This patch uses a throw to drop out of the conversion process if a year before 1970 is encountered. The user will see a generic error message, but a more detailed message will be logged along with the Scheme backtrace.

Not the most user-friendly, but it sure beats the present state: crashing! It would be better to actually have the druid display a non-generic error message, but that's a much larger change (and bug 509089 would need to be fixed too).
Comment 12 Charles Day 2008-01-13 10:13:50 UTC 
Created attachment 102719 [details]
QIF demonstrating the bug
Comment 13 Derek Atkins 2008-01-20 16:58:56 UTC 
Applied to trunk as r16872.
Awaiting backport.
Comment 14 Andreas Köhler 2008-01-30 20:27:30 UTC 
Applied to branches/2.2 as r16892 for GnuCash 2.2.4.
Thanks a lot!
Comment 15 John Ralls 2018-06-29 20:28:32 UTC 
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=106242. Please update any external references or bookmarks.