After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 106215 - make history windows toplevel window
make history windows toplevel window
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
0.x
Other Linux
: Normal enhancement
: ---
Assigned To: Marco Pesenti Gritti
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2003-02-16 05:18 UTC by Dave Bordoley [Not Reading Bug Mail]
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of alternative ui. eg. bookmarks as a top level window (22.45 KB, image/png)
2003-02-19 15:16 UTC, Dave Bordoley [Not Reading Bug Mail]
Details
oh and the column titles should be "Sites" and "Title" (7.06 KB, image/png)
2003-04-14 07:53 UTC, Dave Bordoley [Not Reading Bug Mail]
Details

Description Dave Bordoley [Not Reading Bug Mail] 2003-02-16 05:18:02 UTC
Does it make sense to be able to have more than bookmarks and history
window open?

Right now these dialogs are per window. Is this correct, or should they be
stateful across all browsers. Changing to a one window representation for
these would probably require some ui redesign including making both of
these top level window with menu bars etc. comments? I'm not sure of the
answer really, but a bug to discuss this seems like a good idea to me.
Comment 1 Marco Pesenti Gritti 2003-02-16 09:54:39 UTC
>Does it make sense to be able to have more than bookmarks and history
>window open?

I'm sorry but I dont understand what you mean with this question.

These windows are per window atm but you can still close the window.
Problems with having them global are:
1 Where do you open the url on jump to ?
2 Not transient dialogs sucks

Maybe it's worth to think to the task one want to get done with these
dialog, prioritize them and see if current behavior is bad for the
important tasks.
Anyway, why you are thinking about this change ? What doesnt work in
current behavior ?
I bet the answer is in that question I dont understand ;)
Comment 2 Dave Bordoley [Not Reading Bug Mail] 2003-02-16 14:55:30 UTC
Ok maybe i should have been more clear :)

Right now it is possible to have open multiple bookmark/history
windows per each window. I assume this is easy to fix. However even if
this is fixed per window, it still possible to have multiple bookmark
windows open (ie. one per window), which could be potentially
confusing (I'm not sure yet...).
Comment 3 Dave Bordoley [Not Reading Bug Mail] 2003-02-19 15:16:02 UTC
Created attachment 14443 [details]
Screenshot of alternative ui. eg. bookmarks as a top level window
Comment 4 Marco Pesenti Gritti 2003-02-19 15:27:58 UTC
Personally I dont feel having more than one bookmarks dialog confusing.
I see the dialog more like a place where you can select the page you
want to open in current browser and then close it, than like a central
place where you can open several bookmarks from (so that you want to
keep open but hidden under the other windows). That's why I believe it
should be a transient, per window, dialog.
Just brain storming.
Comment 5 Dave Bordoley [Not Reading Bug Mail] 2003-02-19 15:39:45 UTC
explanation of the above mockup:

In a design as shown above, the bookmarks window would be a unique
(ie. only one bookmarks window can ever be open). 

Menus:
-----
File
-----
Open: 
Opens the currently selected bookmark in the last used window or tab
(similar to the current jump to), alternatively we could just follow
the user "Open in Tabs" pref and open the bookmark in a new window or
tab based on that pref. If no browser windows are open a new window is
opened to the selected bookmark. If a key word is selected, all
bookmarks in that keyword are opened according to the user's "open in
tabs" preferences.

Open in New Window(s):
Similar behavior to open, but the bookmark is always opened in a new
window. Also if a key word is selected the entry changes to "Open in
New Windows," opening all bookmarks in the keyword.

Open in New Tab(s):
Same behavior as "Open in New Window" but uses tabs in the last used
browser window. If no windows are currently opened a new window is
created. Similarly, selecting a keyword changes the entry to "Open in
New Tabs" and opens all bookmarks defined by the keyword in tabs.

<separator/>

Close:
Closes the bookmark window.

-------
Edit
-------
Undo:
Undo the previous action. This would include undoing changes to the
Title, Location and Keyword fields as well as the removal of bookmarks.

Redo:
Redoes undone changes as specified above.

<separator/>

cut
copy
Paste:
Only used to manipulate text entry fields. These entries are greyed
out if focus is not in a text entry box.

<separator/>

Remove Bookmark(s):
Removes the selected bookmark, if a keyword is selected menu changes
to "Remove Bookmakrs" and all bookmarks which include the keyword are
removed. This entry is greyed out if focus is not the keyword or title
trees.

<separator/>

Select All:
Behavior changes depending on context. In text entry boxes it selects
all text. In keyword tree all keyword fields. In the title tree it
selects all bookmarks.


------
Help
------
Contents:
Opens bookmark help

About:
Generic ephy about entry.



-----------------------------------------------------

Using a top level window approach as mentioned here has it's
advantages and disadvantages.

advantages:
1. Top level window is easier to keep open all the time, as it appears
in the window list and is not always ontop of browser windows. This
gives users fast access to the bookmark window.

2. Perhaps is slightly less confusing as only one bookmarks window is
used for all browser windows.

3. We could epiphany --open-bookmmarks-browser (or something like
that) allowing users to add a launcher to the desktop facilitating
fast access to bookmarks without having to open a browser window first
(ie my bookmarks as a folder idea).

Disadvantages:
----------------
The main disadvantage is a slightly more complex ui. Whether the
benefits of increased functionality outweight this, requires further
consideration (i'm personally not sure which is better yet).
Comment 6 Dave Bordoley [Not Reading Bug Mail] 2003-02-19 15:41:23 UTC
re: previous comments

I think we should bring this up on ephy devel, and try to get a handle
on the use case. Perhaps my usage patterns are different than the
majority? 

Comment 7 Marco Pesenti Gritti 2003-02-19 16:34:07 UTC
Sure, it make sense.
Comment 8 Marco Pesenti Gritti 2003-04-11 12:01:38 UTC
Dave, what we do with this ? Bookmarks are done ...
Comment 9 Dave Bordoley [Not Reading Bug Mail] 2003-04-11 17:28:02 UTC
I have a ui proposal for history as a toplevel window floating around
my computer, and i would like to consider if/when we make the history
ui more similar to the bme. Reading some stuff/talking to mpt is
starting to make me think that this is a good idea.

Anyway i would move this to future if we had that as a milestone.
Comment 10 Dave Bordoley [Not Reading Bug Mail] 2003-04-14 07:50:46 UTC
Proposal for toplevel history window:

File
-> _Open in New Window     Ctrl+O
-> Open in New _Tab  Shift+Ctrl+0
-> ------------------------------
-> _Delete
-> _Bookmark Page...       Ctrl+D
-> ------------------------------
-> _Close                  Ctrl+W

Edit
-> Cu_t                    Ctrl+X
-> _Copy                   Ctrl+C
-> _Paste                  Ctrl+P
-> Select _All             Ctrl+A
-> ------------------------------
-> C_lear History

View
-> (*) _Title
-> ( ) _Address
-> ( ) T_itle and Address

Help
-> _Contents                   F1
-> _About

I'll attach a mockup screen shot too.
Comment 11 Dave Bordoley [Not Reading Bug Mail] 2003-04-14 07:53:27 UTC
Created attachment 15695 [details]
oh and the column titles should be "Sites" and "Title"
Comment 12 Marco Pesenti Gritti 2003-04-14 08:21:19 UTC
Shouldnt the From stuff be in view in this case ?
Comment 13 Marco Pesenti Gritti 2003-04-14 08:22:23 UTC
In general I'm starting to hate how histories works (any types of them
I've seen). Wonder if we will ever find a way to make it not suck ;)
Comment 14 Dave Bordoley [Not Reading Bug Mail] 2003-04-14 14:38:12 UTC
Well my guess (from mostly personal experience) is that if the history
dialog went away, very few people would actually complain. History can
be useful, but more often than not I find the type ahead in the entry
much more useful anyway.
Comment 15 Marco Pesenti Gritti 2003-04-18 17:53:29 UTC
The redesign is done. For problems with it (and additions) is prolly
better if we post separate bugs.