After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 104532 - duplicated APIs
duplicated APIs
Status: RESOLVED FIXED
Product: gnome-vfs
Classification: Deprecated
Component: URI handling
unspecified
Other other
: Normal normal
: ---
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
Depends on:
Blocks:
 
 
Reported: 2003-01-28 04:39 UTC by kz
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description kz 2003-01-27 14:35:06 UTC 
Package: gnome-vfs
Severity: trivial
Version: 2.2.0
Synopsis: duplicated APIs
Bugzilla-Product: gnome-vfs
Bugzilla-Component: URI handling

Description:
gnome-vfs-uri.h:gnome_vfs_uri_make_full_from_relative
gnome-vfs-utils.h:gnome_vfs_make_uri_full_from_relative

and those lines of code seems to be duplicated each other.

why both?




------- Bug moved to this database by unknown@bugzilla.gnome.org 2003-01-27 09:35 -------

Reassigning to the default owner of the component, gnome-vfs-maint@bugzilla.gnome.org.
Comment 1 Christophe Fergeau 2003-01-27 19:19:35 UTC 
With latest CVS HEAD, I don't have those duplicated functions, and the
ChangeLog since 2.2.0 doesn't mention any changes in the two files you
mentioned

From gnome-vfs source dir:
$ find . -name "*.[ch]" |xargs grep 
gnome_vfs_uri_make_full_from_relative
./libgnomevfs/gnome-vfs-uri.c: * 
gnome_vfs_uri_make_full_from_relative:
./libgnomevfs/gnome-vfs-uri.c:gnome_vfs_uri_make_full_from_relative 
(const char *base_uri,
./libgnomevfs/gnome-vfs-uri.h:char               
*gnome_vfs_uri_make_full_from_relative (const char *base_uri,
Comment 2 kz 2003-01-28 11:58:23 UTC 
you've missed slight difference between two name of APIs;
one is ...uri_make..., and other is ...make_uri...
Comment 3 Christophe Fergeau 2003-01-28 12:20:51 UTC 
Ooops, you are right, I wasn't paying enought attention, good catch :)
For more duplication fun, make_full_uri_from_relative is also very
similar to the 2 functions you mention...
Comment 4 Christophe Fergeau 2003-02-04 20:52:18 UTC 
Unfortunately, this couldn't be removed from gnome-vfs 2.2, so these
two calls will have to stay :( The one from gnome-vfs-utils.h will be
deprecated though
Comment 5 Christophe Fergeau 2003-04-07 21:03:20 UTC 
Fixed in CVS HEAD