GNOME Bugzilla – Bug 103802
Renaming a "invalid unicode" file should remove the suffix.
Last modified: 2008-10-13 00:28:14 UTC
Package: nautilus Severity: normal Version: GNOME2.1.90 2.1.6 Synopsis: Fixing a "invalid unicode" filename causes "invalid" info to become part of filename Bugzilla-Product: nautilus Bugzilla-Component: File and Folder Operations Description: I've fixed a few files that had broken Unicode characters using label editing and noticed that Nautilus put the information "invalid unicode" into the actual filename. It would be better if that information "invalid unicode" was dynamic and only displayed in the label when it is not in editing mode. It's tiresome to remove Nautilus's annotations as well as the broken characters. ------- Bug moved to this database by unknown@bugzilla.gnome.org 2003-01-18 04:59 ------- Reassigning to the default owner of the component, nautilus-maint@bugzilla.gnome.org.
*** Bug 105966 has been marked as a duplicate of this bug. ***
Marking as new, setting severity->minor and version->2.1.x.
Created attachment 20667 [details] [review] This patch applies to libnautilus-private/nautilus-icon-container.c
Created attachment 20669 [details] [review] This patch applies to src/file-manager/fm-properties-window.c
I had to rename a bunch of files (almost all containing bad Unicode) from a Windows 95 SMB folder, so I decided to work-around this problem on my own local version of Nautilus. If you're interested, I attached the dif files generated by comparing the original source files to the modified ones. I simply replaced the " (invalid Unicode)" (translated) string in the file's name when renaming an icon and when editing the name in the properties window. That's an ugly hack because: - it assumes the error message will never change - it assumes the user didn't actually want the file to be called "something (invalid Unicode)". The two patches I attached were made at about 2am. So forgive their bad quality... The first one applies to libnautilus-private/nautilus-icon-container.c and the second one applies to src/file-manager/fm-properties-window.c. They both apply to Nautilus-2.4.0. That's the first time I try to create a patch for Nautilus. So, please tell me how to make them better and don't hesitate to flame me if they made you lose your time :)
*** Bug 128716 has been marked as a duplicate of this bug. ***
Upgrading to 2.4.x and adding GNOMEVER2.4, GNOMEVER2.5, PATCH & bugsquad keywords.
What sort of format are these patches in? I'd be more than happy to merge the two into an easily applied Superpatch, but I have no clue how to go about that with these files.
Created attachment 23586 [details] [review] A unified patch against Nautilus CVS
I created a patch, using "cvs diff -u", against Nautilus CVS (2.5 not 2.4). I hope it's easier for you to test it.
Bumping the priority because of the patch. Julien, could you also mail the patch (updated if needed) to nautilus-list so that it doesn't get lost in bugzilla noise? PS: using "cvs diff -pu" would be even better
Created attachment 25261 [details] [review] The same patch using cvs diff -up
I re-created the patch using cvs diff -pu and sent it to nautilus-list.
Created attachment 25330 [details] [review] The same patch without the 3 useless "else"...
We don't think that the strange ui effects (changing the displayed name suddenly when the file is renamed) is worth the small amount of effort to replace the (invalid unicode) bit.
*** Bug 154685 has been marked as a duplicate of this bug. ***
*** Bug 326047 has been marked as a duplicate of this bug. ***
Reopening, updating version information. This *is* still relevant and I've heard multiple people complaining about it. I'm marking all the patches as "rejected" because the " (invalid Unicode" string is in eel and it's no good to re-translate it in Nautilus. I think we can only resolve it by offering a demangle_utf8_uri helper to eel or by adding eel_make_valid_utf8 variants with an optional strings that is appended when the UTF8ification failed, which would then be provided by Nautilus.
Added usability keyword. This one really can be a bitch for users. I'd be very glad to see this one fixed in time for 2.14.0. :)
(In reply to comment #19) > Reopening, updating version information. This *is* still relevant and I've "*is* still revelant" ... nobody said it was not, it has been rejected, not marking as fixed
Karsten: You have accidentally set the bug to NEEDINFO.
Doh! How'd I do that? Thanks for correcting this, Christian.
Thanks for taking the time to report this bug. This particular bug has already been reported into our bug tracking system, but we are happy to tell you that the problem has already been fixed. It should be solved in the next software version. You may want to check for a software upgrade. *** This bug has been marked as a duplicate of 326747 ***