After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 103223 - Notification Area needs keynav
Notification Area needs keynav
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: notification area
git master
Other All
: Urgent major
: ---
Assigned To: Li Yuan
Panel Maintainers
AP2
: 155521 372815 395669 (view as bug list)
Depends on: 473786
Blocks: 431030 519089 519313
 
 
Reported: 2003-01-12 22:49 UTC by Mark Finlay
Modified: 2015-03-24 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
adds notification area to the default layout (3.99 KB, patch)
2005-08-21 19:03 UTC, Vincent Untz
committed Details | Review
patch to add focus indicator on tray icon and handle shortcut keys in status icon (3.57 KB, patch)
2007-08-15 08:28 UTC, Li Yuan
none Details | Review

Description Mark Finlay 2003-01-12 22:49:28 UTC
The notification area is a feature that we have promised for 2.2 and a lot
of applications have started using it. It is much more user friendly to
have the notification are sitting on the panel waiting to be used than
to have to find out where it is, what it's called and how to add it to
the panel.

It should "Just work"

Someone said that they don't want to have an extra drag handle on the panel
by default. If it is added to the right of the window list it is totally
un-noticable.
Comment 1 Mark McLoughlin 2003-01-12 22:56:45 UTC
Um, hold on - this was already discussed and the best solution I saw was:

http://mail.gnome.org/archives/desktop-devel-list/2003-January/msg00125.html

Why file a bug which ignores a previous discussion on the subject ?
That's rather annoying ...

Removing TARGET2.2.0 - its not going to be for 2.2.0

Comment 2 Dave Bordoley [Not Reading Bug Mail] 2003-01-25 21:39:33 UTC
WEll if some of the panel applets where switched to notification area
icons, i'd say the ideal location for the notification area is next to
the clock on the top panel.
Comment 3 Alex Duggan 2003-03-20 23:09:48 UTC
moving to GNOMEVER2.2
Comment 4 Mark Finlay 2003-05-25 16:29:11 UTC
Moving to GNOMEVER2.3 - We should probably aim to have the 
notifiaction area working better and on the panel by
default for 2.4. Especially now that a lot of apps in the 
core desktop use. eg. a11y
Comment 5 bill.haneman 2003-06-08 19:07:34 UTC
Mark: accessibility doesn't use the notification area.  One reason for
this is because keyboard navigation appears to be broken for the
notification area.  So if it *is* included by default, I believe some
fixes are required to make it fully keyboard-navigation-friendly.

My recollection is that it breaks TAB and arrow navigation of the
panel, and you can't get to the notification area objects' menus from
the keyboard.  Not sure if this is the case now since my build of the
notification area is a bit stale.
Comment 6 Mark Finlay 2003-12-01 16:31:34 UTC
Marking GNOMEVER2.5 and accessibility.

A lot of apps, including some that we are likely to be shipping now
use the notification area, and redhat and ximian put it on the panel
by default AFAIK. Would be nice to get the A11y stuff fixed before 2.6.

Playing with the notification area in 2.4 tabbing and arrowing on the
panel works fine with the notification area but it is impossible to
get to the context menu for notification area applets.
Comment 7 Calum Benson 2004-01-23 15:27:21 UTC
Updating status whiteboard to reflect a11y team's assessment of priority.
Comment 8 Calum Benson 2004-10-21 15:55:50 UTC
*** Bug 155521 has been marked as a duplicate of this bug. ***
Comment 9 Calum Benson 2004-10-21 16:48:21 UTC
Apologies for spam-- ensuring Sun a11y team are cc'ed on all current a11y bugs.
 Filter on "SUN A11Y SPAM" to ignore.
Comment 10 bill.haneman 2004-10-22 15:42:40 UTC
upgrading priority as the notification area is gaining in importance.
Comment 11 Luis Villa 2005-06-14 13:37:22 UTC
Putting this on the 2.12.x milestone- we won't ship with this broken by default
again.
Comment 12 Vincent Untz 2005-08-21 19:03:22 UTC
Created attachment 51075 [details] [review]
adds notification area to the default layout

This is not tested yet (I'm updating my jhbuild installation right now). Will
test it soon and ask permission for ui freeze breakage.
Comment 13 Vincent Untz 2005-08-22 09:21:33 UTC
Tested and committed (release team approved).
Retitling for the keynav and unsetting the GNOME milestone (I don't think it's a
showstopper anymore, is it?).
Comment 14 bill.haneman 2005-12-01 17:06:43 UTC
This is a big issue for accessibility still - the notification area needs to be
keyboard navigable!  Anyone available for a patch?
Comment 15 Vincent Untz 2006-01-24 19:29:16 UTC
Mass changing: milestone 2.12.x => milestone 2.14.x
Comment 16 Calum Benson 2006-04-26 17:08:43 UTC
Apologies for spam... ensuring Sun a11y folks are cc'ed on all current accessibility bugs.
Comment 17 Tim Miao 2006-11-09 09:22:38 UTC
*** Bug 372815 has been marked as a duplicate of this bug. ***
Comment 18 Vincent Untz 2007-01-15 12:29:13 UTC
*** Bug 395669 has been marked as a duplicate of this bug. ***
Comment 19 Joanmarie Diggs (IRC: joanie) 2007-03-01 16:57:31 UTC
Any progress on this front?  It's a pretty significant issue, especially for users who are blind.

Thanks in advance!!!
Comment 20 Joanmarie Diggs (IRC: joanie) 2007-04-03 14:23:03 UTC
Today a user on the Orca (screen reader) list posted the following:

> It seems that the panel notification area in Gnome 2.18 as shipped
> with Ubuntu Feisty has taken a major step backward with regard to
> accessibility when compared with 2.16 in Edgy. I used to be able to
> access programs in the notification area, albeit by trial and error,
> by counting the times the flat review said `panel'. Now in 2.18 this
> is impossible, since the entire notification area is seen by Orca as a
> single object and I can no longer even guess at a program inside it,
> since the flat review is either on the notification area or it isn't.
> It can no longer detect anything that is inside the notification area
> at all. Is this a known bug? Is a fix on the way? Or is there another
> way to access the programs running in the notification area that I am
> currently unaware of?

It would be EXTREMELY helpful to have keyboard access to the notification area so that we can provide access to its contents.

Sorry to be a noodge, and thanks (again) in advance for your help!!!
Comment 21 Mike Pedersen 2007-05-04 20:17:52 UTC
This bug is becoming more and more of a problem for those of us who are blind and exclusively use the keyboard to navigate.  Apps that I can think of that I can't access correctly because of this include nm-applet, the gaim applet, the ekiga applet, and so on.  I'm really hoping that this can be addressed for 2.20.  
thanks muchh 
Comment 22 Willie Walker 2007-05-15 18:46:45 UTC
I'm CC'ing Patrick Wade on this to see if he has any insight.  Patrick?  Want to be a hero on a horrible bug that's over 4 years old?  :-)
Comment 23 Willie Walker 2007-05-29 16:38:11 UTC
I'm marking the priority of this as "Urgent" since the lack of keyboard navigation affects the usability of gnome-panel by people who cannot use the mouse.  We desperately need this fixed, and we constantly get complaints and questions about why this is broken in gnome-panel.
Comment 24 Vincent Untz 2007-05-29 21:34:28 UTC
I thought I had put a comment about this, but it seems it's not the case. I know this bug is important, but I probably won't have time for it in the short term. Outside help is really welcome.
Comment 25 Willie Walker 2007-06-01 23:40:23 UTC
(In reply to comment #24)
> I thought I had put a comment about this, but it seems it's not the case. I
> know this bug is important, but I probably won't have time for it in the short
> term. Outside help is really welcome.

You bet Vincent!  We're recruiting internally and hopefully have found someone to investigate.
Comment 26 Patrick Wade 2007-06-05 14:49:38 UTC
I'll have a looksy at this one.
Comment 27 Willie Walker 2007-07-10 15:48:19 UTC
(In reply to comment #26)
> I'll have a looksy at this one.
> 

Hey Patrick - thanks so much!  Any luck with this one?
Comment 28 Li Yuan 2007-07-31 10:24:38 UTC
I took a look at this. Seems notification area acts as both a gtkplug and a gtksocket: gtkplug to communicate with gnome-panel, gtksocket to communicate with applications which would create an icon on panel.(not sure if I am right on this). When focus signal comes, both the gtkplug and the gtksocket are noticed by gdk_event_apply_filters. So the "focus" signal are handled twice and the focus just jump out to the next widget. 
Comment 29 Yi Jin 2007-08-01 09:59:03 UTC
I guess , gdk_event_apply_filters is called twice, for two different GtkEvents trigger it.
the two events have diffent addresses saved in field window, print by gdb like this:

the first event:
{type = GDK_NOTHING, window = 0x8078960, send_event = 1 '\001', in = 0}

the second event:
{type = GDK_NOTHING, window = 0x8078b70, send_event = 1 '\001', in = 0}

it is a GdkWindow object , how can I get the gtk object ? or other useful things through this address ? THX!
Comment 30 Yi Jin 2007-08-13 07:57:40 UTC
li.yuan@sun.com and I have found the reason :)

Generally, An application uses a GtkImage to show picture. The image object has can not be focused by default. i.e. GTK_WIDGET_CAN_FOCUS(GTK_WIDGET(image)) == FALSE. 

So When the application's plug object handles FOCUS_IN message, it can not find a GTK object to grab the focus, so it generates  message GTK_DIR_TAB_FORWARD back to the area process. 

The area will try the next application's plug.If all the applications' plug can not grab focus, the focus will be moved out. It is very reasonable. 

We use stardict to reproduce this bug, and stardict's trace is :


  • #0 _gtk_plug_windowing_focus_to_parent
    at gtkplug-x11.c line 95
  • #1 gtk_plug_focus
    at gtkplug.c line 908
  • #2 _gtk_marshal_BOOLEAN__ENUM
    at gtkmarshalers.c line 164
  • #3 g_type_class_meta_marshal
    at gclosure.c line 567
  • #4 IA__g_closure_invoke
    at gclosure.c line 490
  • #5 signal_emit_unlocked_R
    at gsignal.c line 2478
  • #6 IA__g_signal_emit_valist
    at gsignal.c line 2209
  • #7 IA__g_signal_emit
    at gsignal.c line 2243
  • #8 IA__gtk_widget_child_focus
    at gtkwidget.c line 6777
  • #9 _gtk_plug_focus_first_last
    at gtkplug.c line 990
  • #10 handle_xembed_message
    at gtkplug-x11.c line 169
  • #11 _gtk_plug_windowing_filter_func
    at gtkplug-x11.c line 220
  • #12 gdk_event_apply_filters
    at gdkevents-x11.c line 345
  • #13 gdk_event_translate
    at gdkevents-x11.c line 984
  • #14 _gdk_events_queue
    at gdkevents-x11.c line 2285
  • #15 gdk_event_dispatch
    at gdkevents-x11.c line 2345
  • #16 g_main_dispatch
    at gmain.c line 2061
  • #17 IA__g_main_context_dispatch
    at gmain.c line 2613

------------------------------------------------------------
To solve this bug, the application's image object should have the property GTK_CAN_FOCUS . We modified the stardict's code by setting the image :

GTK_WIDGET_SET_FLAGS (image, GTK_CAN_FOCUS);

then the image can grab the focus when we use tab to move the focus onto it. 
Of cause, in this simple way we can not see it performs perfectly like a button. 
Comment 31 Li Yuan 2007-08-13 09:04:13 UTC
And we plan to make a patch for gtkstatusicon, we will also support keyboard shortcuts. For those applications embed image into gnome-panel without using statusicon, they need to fix this by themselves.
Comment 32 Li Yuan 2007-08-15 08:28:18 UTC
Created attachment 93708 [details] [review]
patch to add focus indicator on tray icon and handle shortcut keys in status icon

Hi Matthias, would you like help me to review the patch?
Comment 33 Vincent Untz 2007-09-02 15:02:30 UTC
Should the bug be moved to gtk+ or is a patch needed for the notification area too?
Comment 34 Li Yuan 2007-09-03 01:50:39 UTC
There will not be a patch for notification area I think. But it is not only a bug in gtk+. Some applications has their own way to add icons in notification area instead of using gtkstatusicon. So I'm not sure where this bug should be...
Comment 35 Vincent Untz 2007-09-03 11:14:39 UTC
Well this bug is old, have been used for many things and is against gnome-panel. A new bug for GTK+ might be better.
Comment 36 David Bolter 2007-09-04 16:16:31 UTC
Did the patch ever make it over to a gtk+ bug?
Comment 37 Li Yuan 2007-09-05 04:37:31 UTC
Please refer to http://bugzilla.gnome.org/show_bug.cgi?id=473786
Comment 38 Vincent Untz 2008-06-06 08:47:27 UTC
Seems to be working now, thanks to GTK+ being fixed. Please reopen if I'm missing something.